Skip to content

OCPBUGS-87100: fix trailing quote in prometheus query#16552

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.20from
dsimansk:pr/fix-OCPBUGS-87100
Jun 5, 2026
Merged

OCPBUGS-87100: fix trailing quote in prometheus query#16552
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.20from
dsimansk:pr/fix-OCPBUGS-87100

Conversation

@dsimansk

@dsimansk dsimansk commented Jun 4, 2026

Copy link
Copy Markdown

JIra Bug Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87100

Analysis / Root cause:

Per several reports after upgrading cluster to 4.20.23 the dashboard "Control Plane" icon is never appearing green. That might be indicating an issue.

Per one of the reports there was HTTP 400 captured in the browsernetwork log
Screenshot 2026-06-04 at 16 16 41

A previous change introduces a trailing " quote probably by accident.
https://github.com/openshift/console/pull/16308/changes#diff-6535e1527287e98a5b1682350eb702d6fa24be9bc798a1b18745a93853883375R15

Solution description:

Fix the " to expected '.

Screenshots / screen recording:

Screenshot 2026-06-04 at 16 14 50

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@dsimansk: This pull request references Jira Issue OCPBUGS-87100, which is invalid:

  • expected the bug to target the "4.20.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-87100 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

JIra Bug Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87100

Analysis / Root cause:

Per several reports after upgrading cluster to 4.20.23 the dashboard "Control Plane" icon is never appearing green. That might be indicating an issue.

Per one of the reports there was HTTP 400 captured in the browsernetwork log
Screenshot 2026-06-04 at 16 16 41

A previous change introduces a trailing " quote probably by accident.

Solution description:

Fix the " to expected '.

Screenshots / screen recording:

Screenshot 2026-06-04 at 16 14 50

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from TheRealJon and sg00dwin June 4, 2026 14:17
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Jun 4, 2026
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e79bdf92-a591-41ce-b5e1-5b671e5969f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@dsimansk: This pull request references Jira Issue OCPBUGS-87100, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-87100 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

JIra Bug Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87100

Analysis / Root cause:

Per several reports after upgrading cluster to 4.20.23 the dashboard "Control Plane" icon is never appearing green. That might be indicating an issue.

Per one of the reports there was HTTP 400 captured in the browsernetwork log
Screenshot 2026-06-04 at 16 16 41

A previous change introduces a trailing " quote probably by accident.
https://github.com/openshift/console/pull/16308/changes#diff-6535e1527287e98a5b1682350eb702d6fa24be9bc798a1b18745a93853883375R15

Solution description:

Fix the " to expected '.

Screenshots / screen recording:

Screenshot 2026-06-04 at 16 14 50

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dsimansk

dsimansk commented Jun 4, 2026

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@dsimansk: This pull request references Jira Issue OCPBUGS-87100, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-87159 to target a version in 4.21.0, 4.21.z, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dsimansk

dsimansk commented Jun 4, 2026

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@dsimansk: This pull request references Jira Issue OCPBUGS-87100, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-87159 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-87159 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dsimansk

dsimansk commented Jun 4, 2026

Copy link
Copy Markdown
Author

/test e2e-gcp-console

seems like infra networking issue

➤ YN0000: │ cypress@npm:14.2.1 STDOUT URL: https://download.cypress.io/desktop/14.2.1?platform=linux&arch=x64
➤ YN0000: │ cypress@npm:14.2.1 STDOUT Error: getaddrinfo EAI_AGAIN cdn.cypress.io

@dsimansk

dsimansk commented Jun 4, 2026

Copy link
Copy Markdown
Author

@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@dsimansk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2026
@logonoff

logonoff commented Jun 5, 2026

Copy link
Copy Markdown
Member

/verified by #16552 (comment)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 5, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@logonoff: This PR has been marked as verified by https://github.com/openshift/console/pull/16552#issuecomment-4624786662.

Details

In response to this:

/verified by #16552 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff

logonoff commented Jun 5, 2026

Copy link
Copy Markdown
Member

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 5, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 76c97d2 into openshift:release-4.20 Jun 5, 2026
7 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@dsimansk: Jira Issue Verification Checks: Jira Issue OCPBUGS-87100
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-87100 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

JIra Bug Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87100

Analysis / Root cause:

Per several reports after upgrading cluster to 4.20.23 the dashboard "Control Plane" icon is never appearing green. That might be indicating an issue.

Per one of the reports there was HTTP 400 captured in the browsernetwork log
Screenshot 2026-06-04 at 16 16 41

A previous change introduces a trailing " quote probably by accident.
https://github.com/openshift/console/pull/16308/changes#diff-6535e1527287e98a5b1682350eb702d6fa24be9bc798a1b18745a93853883375R15

Solution description:

Fix the " to expected '.

Screenshots / screen recording:

Screenshot 2026-06-04 at 16 14 50

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 4.20.0-0.nightly-2026-06-05-230804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants