Skip to content

[release-4.22] OCPBUGS-101997: Bump golang.org/x/net to v0.53.0 - #415

Open
mariocr73 wants to merge 1 commit into
openshift:release-4.22from
mariocr73:ocpbugs-101997-cve-2026-33814-xnet-bump
Open

[release-4.22] OCPBUGS-101997: Bump golang.org/x/net to v0.53.0#415
mariocr73 wants to merge 1 commit into
openshift:release-4.22from
mariocr73:ocpbugs-101997-cve-2026-33814-xnet-bump

Conversation

@mariocr73

Copy link
Copy Markdown

What this PR does / why we need it:
Bumps golang.org/x/net from v0.48.0 to v0.53.0 to fix CVE-2026-33814 (GO-2026-4918), an infinite loop in the HTTP/2 transport triggered by a malformed SETTINGS_MAX_FRAME_SIZE frame. Reachable via keystone.NewKeystoneAuth -> http2.Transport. Verified with govulncheck before/after (no longer reported) and go build/go vet ./... clean across the whole repo.

Jira: OCPBUGS-101997

Special notes for reviewers:
go.mod's go directive stays at 1.25.5 (no toolchain bump). The vendor diff also includes mandatory transitive bumps (x/crypto, x/sys, x/term, x/text, and via x/text: x/tools/x/sync/x/mod) — required by x/net@v0.53.0's own
go.mod, not optional/unrelated churn.

@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mariocr73: This pull request references Jira Issue OCPBUGS-101997, which is invalid:

  • expected Jira Issue OCPBUGS-101997 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
Bumps golang.org/x/net from v0.48.0 to v0.53.0 to fix CVE-2026-33814 (GO-2026-4918), an infinite loop in the HTTP/2 transport triggered by a malformed SETTINGS_MAX_FRAME_SIZE frame. Reachable via keystone.NewKeystoneAuth -> http2.Transport. Verified with govulncheck before/after (no longer reported) and go build/go vet ./... clean across the whole repo.

Jira: OCPBUGS-101997

Special notes for reviewers:
go.mod's go directive stays at 1.25.5 (no toolchain bump). The vendor diff also includes mandatory transitive bumps (x/crypto, x/sys, x/term, x/text, and via x/text: x/tools/x/sync/x/mod) — required by x/net@v0.53.0's own
go.mod, not optional/unrelated churn.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e19c3ec-0436-47e4-9df3-8014b2662f0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from gryf and mandre August 19, 2026 17:13
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mariocr73
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

CVE-2026-33814 (GO-2026-4918): infinite loop in HTTP/2 transport when
given a malformed SETTINGS_MAX_FRAME_SIZE frame. Reachable via
keystone.NewKeystoneAuth -> http2.Transport.NewClientConn.
Verified with govulncheck before/after: GO-2026-4918 no longer
reported. go.mod's go directive stays at 1.25.5 (no toolchain bump
needed on this branch). go vet/go build verified clean across the
whole repo (not just cmd/), in both module-cache and vendor mode.
go test ./... run as a control: the 3 failing packages (CSI sanity/
e2e suites) fail identically on the unmodified code, confirming they
are pre-existing/environmental, not caused by this bump.
@mariocr73
mariocr73 force-pushed the ocpbugs-101997-cve-2026-33814-xnet-bump branch from e33781b to 88af41d Compare August 19, 2026 18:35
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

@mariocr73: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 88af41d link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jkaurredhat

Copy link
Copy Markdown

/label jira/skip-dependent-bug-check

@openshift-ci openshift-ci Bot added the jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. label Aug 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mariocr73: This pull request references Jira Issue OCPBUGS-101997, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

What this PR does / why we need it:
Bumps golang.org/x/net from v0.48.0 to v0.53.0 to fix CVE-2026-33814 (GO-2026-4918), an infinite loop in the HTTP/2 transport triggered by a malformed SETTINGS_MAX_FRAME_SIZE frame. Reachable via keystone.NewKeystoneAuth -> http2.Transport. Verified with govulncheck before/after (no longer reported) and go build/go vet ./... clean across the whole repo.

Jira: OCPBUGS-101997

Special notes for reviewers:
go.mod's go directive stays at 1.25.5 (no toolchain bump). The vendor diff also includes mandatory transitive bumps (x/crypto, x/sys, x/term, x/text, and via x/text: x/tools/x/sync/x/mod) — required by x/net@v0.53.0's own
go.mod, not optional/unrelated churn.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants