OCPBUGS-127072: spell FeatureGate DynamicServiceEndpointIBMCloud correctly

[PratikUplenchwar]

Summary

• Renames FeatureGate DyanmicServiceEndpointIBMCloud to DynamicServiceEndpointIBMCloud (Go identifier, API token, tests, and generated manifests).
• Fixes OCPBUGS-127072: the misspelled name is what showed up on FeatureGate/cluster (disabled) for 5.0.0-rc.2.
• Gate contact is jared-hayes-dev. Bug assignee is Szepesi Zoltan (Installer / IBM Cloud).

Compatibility

This gate is TechPreviewNoUpgrade / DevPreviewNoUpgrade on master (not Default). Anyone enabling the misspelled name via CustomNoUpgrade must switch to DynamicServiceEndpointIBMCloud. Installer and other consumers keep the old token until they vendor this API.

Test plan

• git grep Dyanmic is empty in this repo
• FeatureGate/cluster lists DynamicServiceEndpointIBMCloud (not DyanmicServiceEndpointIBMCloud)
• CustomNoUpgrade enablement uses the corrected name

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @PratikUplenchwar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@PratikUplenchwar: This pull request references Jira Issue OCPBUGS-127072, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Renames FeatureGate DyanmicServiceEndpointIBMCloud to DynamicServiceEndpointIBMCloud (Go identifier, API token, tests, and generated manifests).
• Fixes OCPBUGS-127072: the misspelled name is what showed up on FeatureGate/cluster (disabled) for 5.0.0-rc.2.
• Gate contact is jared-hayes-dev. Bug assignee is Szepesi Zoltan (Installer / IBM Cloud).

Compatibility

This gate is TechPreviewNoUpgrade / DevPreviewNoUpgrade on master (not Default). Anyone enabling the misspelled name via CustomNoUpgrade must switch to DynamicServiceEndpointIBMCloud. Installer and other consumers keep the old token until they vendor this API.

Test plan

• git grep Dyanmic is empty in this repo
• FeatureGate/cluster lists DynamicServiceEndpointIBMCloud (not DyanmicServiceEndpointIBMCloud)
• CustomNoUpgrade enablement uses the corrected name

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 02cadf06-69e9-45b3-9996-1ee12c7ef052

📥 Commits

Reviewing files that changed from the base of the PR and between 0616345 and 54dda23.

⛔ Files ignored due to path filters (4)

• config/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/zz_generated*
• config/v1/zz_generated.featuregated-crd-manifests/infrastructures.config.openshift.io/DynamicServiceEndpointIBMCloud.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• machineconfiguration/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/zz_generated*
• machineconfiguration/v1/zz_generated.featuregated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/DynamicServiceEndpointIBMCloud.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**

📒 Files selected for processing (13)

• config/v1/tests/infrastructures.config.openshift.io/DynamicServiceEndpointIBMCloud.yaml
• config/v1/types_infrastructure.go
• features.md
• features/features.go
• machineconfiguration/v1/tests/controllerconfigs.machineconfiguration.openshift.io/DynamicServiceEndpointIBMCloud.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The feature-gate name changes from DyanmicServiceEndpointIBMCloud to DynamicServiceEndpointIBMCloud in its registration, API validations and markers, test fixtures, feature documentation, and payload manifests. The feature-gate enablement settings remain unchanged.

Suggested reviewers: vr4manta

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 54dda

No established issue remains that would block merging the feature-gate rename.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only the static feature-gate spelling and related fixture filenames. The YAML test name values remain unchanged, and the patch adds no Ginkgo It, Describe, `Contex…
Test Structure And Quality	✅ Passed	PASS: The pull request changes no Ginkgo test code. The two changed files under */tests/ are declarative YAML fixtures, and their test content is unchanged except for the feature-gate token rename. …
Microshift Test Compatibility	✅ Passed	PASS: The PR adds no new Ginkgo e2e tests. The only changed test files are declarative YAML fixtures, and the added lines only rename the feature-gate token. The MicroShift compatibility check is ther…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request adds no Ginkgo e2e tests or test constructs. The only changed test paths are YAML API test fixtures, where the feature-gate token is renamed. No multi-node or HA assumption is introdu…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request only renames the DynamicServiceEndpointIBMCloud feature-gate token and updates related API validation markers, generated manifests, tests, and feature tables. The diff adds no…
Ote Binary Stdout Contract	✅ Passed	The pull request only renames a feature-gate identifier/token and updates YAML, generated metadata, and validation comments. The changed top-level initializer calls the existing builder; that builder …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds no new Ginkgo e2e tests. The changed test YAML files only rename the feature-gate fixture path and token. Their dummy HTTPS URLs are validation data; the tests do not connect to …
No-Weak-Crypto	✅ Passed	PASS: The review-scoped diff only renames the IBM Cloud feature-gate token and updates matching generated manifests, tests, and validation markers. The changed Go code contains no cryptographic implem…
Container-Privileges	✅ Passed	The pull request only renames the IBM Cloud feature gate in Go, test descriptors, CRD metadata, and FeatureGate data. The diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPri…
No-Sensitive-Data-In-Logs	✅ Passed	The PR only corrects the DynamicServiceEndpointIBMCloud spelling across Go annotations, generated manifests, tests, and feature metadata. The authoritative diff adds no logging calls, log messages, …
Title check	✅ Passed	The title clearly summarizes the main change: correcting the FeatureGate identifier to DynamicServiceEndpointIBMCloud.
Description check	✅ Passed	The description directly explains the rename, affected artifacts, compatibility impact, and test plan.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@PratikUplenchwar: This pull request references Jira Issue OCPBUGS-127072, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary

• Renames FeatureGate DyanmicServiceEndpointIBMCloud to DynamicServiceEndpointIBMCloud (Go identifier, API token, tests, and generated manifests).
• Fixes OCPBUGS-127072: the misspelled name is what showed up on FeatureGate/cluster (disabled) for 5.0.0-rc.2.
• Gate contact is jared-hayes-dev. Bug assignee is Szepesi Zoltan (Installer / IBM Cloud).

Compatibility

This gate is TechPreviewNoUpgrade / DevPreviewNoUpgrade on master (not Default). Anyone enabling the misspelled name via CustomNoUpgrade must switch to DynamicServiceEndpointIBMCloud. Installer and other consumers keep the old token until they vendor this API.

Test plan

• git grep Dyanmic is empty in this repo
• FeatureGate/cluster lists DynamicServiceEndpointIBMCloud (not DyanmicServiceEndpointIBMCloud)
• CustomNoUpgrade enablement uses the corrected name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview
/test minor-e2e-upgrade-minor

[everettraven]

@PratikUplenchwar I've triggered the required CI jobs to see if there is any impact to platform components with this rename. Components will panic if they cannot find the feature gate they depend on which will impact all of CI.

Instead of simply renaming, we may need to introduce a new gate with the new name, migrate all components that depend on it to use that new feature gate name, and then drop the old misspelled name.

[openshift-ci]

@PratikUplenchwar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	54dda23	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-azure	54dda23	link	true	/test e2e-azure
ci/prow/e2e-aws-ovn-techpreview	54dda23	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift-conformance	54dda23	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-serial-techpreview-2of2	54dda23	link	true	/test e2e-aws-serial-techpreview-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.