OCPBUGS-126808: Enable OLMLifecycleAndCompatibility by default in version 5+ - #3045
joelanford wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Hello @joelanford! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The OLM lifecycle feature is disabled in all version-4 configurations and enabled from version 5 onward, which matches the agreed release plan. No blocking risk remains. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 golangci-lint (2.13.2)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
|
/retest |
|
@joelanford Any particular reason we want this only enabled in 5+? |
|
There's a large amount of extra work to do in the layered product ecosystem and pipeline to populate the data that this feature relies on. The BU would rather engineering focus efforts on OLMv1 MVP and the next round of update planner features rather than spend additional cycles making this feature worthwhile to enable in 4.23. |
|
@joelanford: This pull request references Jira Issue OCPBUGS-126808, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@joelanford: This pull request references Jira Issue OCPBUGS-126808, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-5.0 |
|
@joelanford: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Is there something in Jira that tracks a BU decision to not ship this in 4.23? |
52cc75e to
7f93dc8
Compare
7f93dc8 to
0cd9983
Compare
|
/pipeline required |
|
Scheduling tests matching the |
|
/test e2e-aws-serial-2of2 |
|
/override-sticky ci/prow/e2e-gcp Automated triage: This failure appears unrelated to the PR changes. Job classification: Eligible long-running GCP IPI end-to-end presubmit. The definition uses the If you disagree with this assessment, rerun the current job with AI-generated. Review for accuracy. |
|
@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-gcp These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override-sticky ci/prow/e2e-aws-ovn Automated triage: This failure appears unrelated to the PR changes. Job classification: Eligible long-running e2e/integration presubmit. The job uses the If you disagree with this assessment, rerun the current job with AI-generated. Review for accuracy. |
|
@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-aws-ovn These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve cancel As far as I can tell the BU has not approved this to not ship in 4.23. In fact it appears they explicitly want this one in 4.23, this needs further discussion |
|
/approve Discussion was had yesterday and BU are now aligned at all layers, per comment in slack we are going to drop this feature from 4.23 |
|
@redhat-chai-bot can you assess the two failing checks to see if they should be overridden? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed — I've assessed both failing checks. Neither failure is related to the PR changes (enabling 1.
2.
Both failures appear to be flaky/infrastructure issues. I'm unable to run AI-generated. Review for accuracy. |
|
/override ci/prow/e2e-aws-ovn-techpreview |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-techpreview, ci/prow/minor-e2e-upgrade-minor DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0cd9983 to
5c13b5e
Compare
|
New changes are detected. LGTM label has been removed. |
|
/pipeline required |
|
Scheduling tests matching the |
|
@joelanford: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Enables the
OLMLifecycleAndCompatibilityfeature gate by default starting in OpenShift version 5.The effective change here is removing this feature from 4.23.
The feature gate remains enabled for the existing
SelfManaged,OKD,TechPreviewNoUpgrade, andDevPreviewNoUpgradeconfigurations.