Conversation
Contributor
Author
|
@smarterclayton @liggitt objections to the overall shape? The carry shouldn't hurt anyone trying to vendor us since its only related to generation. The level they get will be fine. |
sttts
reviewed
Oct 27, 2017
| package: github.com/openshift/api | ||
| import: | ||
| - package: k8s.io/gengo | ||
| version: master |
Contributor
There was a problem hiding this comment.
master is wrong, compare https://github.com/openshift-evangelists/crd-code-generation/blob/master/Gopkg.toml
sttts
reviewed
Oct 27, 2017
| set -o pipefail | ||
|
|
||
| SCRIPT_ROOT=$(dirname ${BASH_SOURCE})/.. | ||
| CODEGEN_PKG=${CODEGEN_PKG:-$(cd ${SCRIPT_ROOT}; ls -d -1 ./vendor/k8s.io/code-generator 2>/dev/null || echo ../code-generator)} |
Contributor
There was a problem hiding this comment.
../../../k8s.io/code-generator as we are not in kube.
Contributor
|
Looks good! |
Merged
clnperez
added a commit
to clnperez/api
that referenced
this pull request
Jun 28, 2021
api first pass for powervs
frobware
pushed a commit
to frobware/api
that referenced
this pull request
Jul 30, 2021
add AlibabaCloudResourceTag for Alibaba Cloud
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/openshift/api/build/v1