8381611: RISC-V: Factor out function cmpptr from MacroAssembler

[DingliZhang]

Hi, please consider.

Currently, there isn't much use of MacroAssembler::cmpptr on RISC-V.
This small macro-assembler routine seems very specific to the use case in MethodHandles::verify_klass.
And it doesn't look obvious from its name that it actually changes control flow at the same time.
We can simply inline the code to its callsites, which will be more straightforward.

Testing: hotspot:tier1 using fastdebug build on linux-riscv64 platform.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381611: RISC-V: Factor out function cmpptr from MacroAssembler (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30562/head:pull/30562
$ git checkout pull/30562

Update a local copy of the PR:
$ git checkout pull/30562
$ git pull https://git.openjdk.org/jdk.git pull/30562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30562

View PR using the GUI difftool:
$ git pr show -t 30562

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30562.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381611: RISC-V: Factor out function cmpptr from MacroAssembler

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• f21e47d: 8381549: GenShen: Global collections skip coalesce and fill when the collection set is empty
• a333111: 8380291: AOT cache should store only unregistered classes with file: code source
• e254526: 8380958: GenShen: Regulator thread may observe inconsistent old generation state
• ... and 4 more: https://git.openjdk.org/jdk/compare/f8ca6f6f09908c5106d262cfaaf82e88f37e9a32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@DingliZhang The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (66d105d6)

[RealFYang]

Looks fine.