Apply extra templates on vs2019 and vs2026 - #8552
Closed
danoli3 wants to merge 2 commits into
Closed
Conversation
PG matches template.config PLATFORMS with an exact token, so "vs" does not cover vs2019/vs2026. Add those targets to vscode and the other extra templates that already listed vs, so VSCode overlay, gitignore, GL, nowindow, and unittest apply for VS 2019 and 2026.
MSYS2's default environment is UCRT64 (MINGW64 is deprecated). The vscode template still launched msys2_shell.cmd -mingw64, so VSCode builds did not match install_dependencies.sh (ucrt64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/templates/vscodealready exists and is labeled Visual Studio Code. Itstemplate.configlistedvsas a supported overlay platform, so Windows+MSVC users on VS 2022 (vs) can pick it today.PG compares
PLATFORMSwith an exact token (platform == target).vs2019andvs2026do not matchvs, so the VSCode overlay (and other extras that only listedvs) never applied for those two.Change
Add
vs2019 vs2026next tovson:scripts/templates/vscode/template.config(the reported gap)vs: gitignore, nowindow, unittest, gl3.1–gl4.5No new VSCode template; this only extends where the existing overlay is allowed.