Skip to content

fix: posix cli commands - #3348

Merged
maki5 merged 6 commits into
mainfrom
fix/posix_cli_commands
Sep 1, 2026
Merged

fix: posix cli commands#3348
maki5 merged 6 commits into
mainfrom
fix/posix_cli_commands

Conversation

@maki5

@maki5 maki5 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
  • Fix CLI restoration of a single trash-bin item and listing an empty trash bin.
  • Fix shares CLI cleanup jsoncs3 configuration.
  • Propagate CLI cleanup failures instead of silently reporting success.
  • Fix CLI revisions purge on POSIX
  • Fix CLI trash purge empty dirs on POSIX

closes #3095

@codacy-production

codacy-production Bot commented Aug 18, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

🟢 Coverage 15.22% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage 15.22% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7d4c6d6) 85829 20129 23.45%
Head commit (d923bfe) 85884 (+55) 20146 (+17) 23.46% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3348) 92 14 15.22%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@v-scharf

Copy link
Copy Markdown
Contributor

LGTM from testing side

Comment thread opencloud/pkg/command/trash.go Outdated
Comment thread opencloud/pkg/trash/trash.go Outdated

@butonic butonic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reva changes should be part of a dedicated reva bump. That should also remove the other vondor stuff being pulled in.

@maki5

maki5 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

The reva changes should be part of a dedicated reva bump. That should also remove the other vondor stuff being pulled in.

without reva change(which was already merged to main) the tests will fail, that's why I bumped it in this pr

@maki5
maki5 requested a review from butonic August 21, 2026 14:55

@fschade fschade left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @maki5 needs a rebase

@maki5
maki5 force-pushed the fix/posix_cli_commands branch from 88e345e to d923bfe Compare September 1, 2026 08:29
@maki5
maki5 merged commit 5a7afe0 into main Sep 1, 2026
66 of 67 checks passed
@maki5
maki5 deleted the fix/posix_cli_commands branch September 1, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POSIX: failing CLI commands

4 participants