Skip to content

fix(test): run subprocess before reading stdout/stderr buffers #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fullstackjam merged 2 commits into from
Apr 21, 2026
+4 −3
Merged

fix(test): run subprocess before reading stdout/stderr buffers #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
424321f
fix(publish): route publish status messages to stderr
fullstackjam Apr 21, 2026
5b4a657
fix(test): run subprocess before reading stdout/stderr buffers
fullstackjam Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/cli/snapshot_publish.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ func publishSnapshot(ctx context.Context, snap *snapshot.Snapshot, explicitSlug
var configName, configDesc, visibility string
if targetSlug != "" {
fmt.Fprintln(os.Stderr)
ui.Info(fmt.Sprintf("Publishing to @%s/%s (updating)", stored.Username, targetSlug))
fmt.Fprintf(os.Stderr, " Publishing to @%s/%s (updating)\n", stored.Username, targetSlug)
} else {
fmt.Fprintln(os.Stderr)
ui.Info("Publishing as a new config on openboot.dev")
fmt.Fprintln(os.Stderr, " Publishing as a new config on openboot.dev")
configName, configDesc, visibility, err = promptPushDetails("")
if err != nil {
return err
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/publish_import_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ func runBinary(t *testing.T, binary string, env []string, args ...string) (stdou
var outBuf, errBuf strings.Builder
cmd.Stdout = &outBuf
cmd.Stderr = &errBuf
return outBuf.String(), errBuf.String(), cmd.Run()
err = cmd.Run()
return outBuf.String(), errBuf.String(), err
}

// ── tests ─────────────────────────────────────────────────────────────────────
Expand Down
Loading