Skip to content

Check semver compatibility on pull requests - #16

Open
LucaCappelletti94 wants to merge 1 commit into
openapi:mainfrom
LucaCappelletti94:ci/semver-checks
Open

LucaCappelletti94 wants to merge 1 commit into
openapi:mainfrom
LucaCappelletti94:ci/semver-checks

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

This PR adds a workflow that runs cargo-semver-checks on every pull request against the latest crates.io release, so a change that removes or renames public API fails CI unless the version in Cargo.toml is bumped to match.

@francescobianco francescobianco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you! See my comment below for the merge order.

@francescobianco

Copy link
Copy Markdown
Member

@LucaCappelletti94 thank you, this closes the loop nicely! 🙏 Approved. I'll merge it right after #15, as you planned: that way the breaking Client::new(&str) change lands first and the semver job starts guarding main from the next PR on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants