Conversation
3 tasks
The Responses stream accumulator assumed event.item is always present for response.output_item.added events and immediately accessed event.item.type. When an OpenAI-compatible provider sends this event with item=None, the client crashes with: AttributeError: 'NoneType' object has no attribute 'type' Add a defensive None check so the accumulator gracefully skips malformed events instead of crashing. Closes openai#3125 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
sharziki
force-pushed
the
fix/3125-stream-accumulator-null-item
branch
from
June 6, 2026 22:29
fec1f1f to
2a90721
Compare
Contributor
|
Thanks for the patch! We merged the fix in #3126, so closing this as a duplicate. We appreciate your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3125
The Responses stream accumulator assumed every
response.output_item.addedevent includes a non-nullitemand immediately accessedevent.item.type. OpenAI-compatible providers can emit this event withitem=None, which crashes streaming withAttributeError.Changes
src/openai/lib/streaming/responses/_responses.py: Add a defensiveNonecheck before inspectingevent.item.type, so malformed/null output-item events are skipped instead of crashing the stream accumulatorVerification
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com