Repository navigation
[sandbox-hardening] Avoid loading startup files during workspace operations - #5406
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Automated source review of 2a8915fc4d8759e301c713e1b6ba033d40ff1a90: approved. No actionable findings in the six-file diff.
The fixed file-operation checks and workspace fingerprint helper now use non-login shells while preserving argument handling, explicit command execution, and snapshot compatibility. The regression tests exercise the real Runner path, approval and rejection, saved content, and cleanup. The existing content-based helper installation also picks up the revised script.
All 23 hosted checks pass at this commit, including Python 3.10–3.14 tests, Windows tests, native macOS sandbox, containers, lint, type checks, and CodeQL. I reviewed immutable source and existing test/CI evidence; I did not run candidate code or tests locally. Protected merge checks remain in force.
Summary
SDK file checks and snapshot creation start login shells, which can load shell startup files from the workspace. Change those helper commands from
sh -lctosh -cso they do not execute workspace startup files.Add regression tests for snapshot saving, shell approval outcomes, and file checks.
Test plan
Issue number
Fixes PSEC-10090
Checks
.agents/skills/code-change-verification/scripts/run.sh.