Repository navigation
Conversation
lmolkova
force-pushed
the
lmolkova/typed-span-record-exception
branch
from
October 23, 2026 23:24
36dd2cd to
1ef3e8d
Compare
Pull request dashboard statusWaiting on the author · refreshed 2026-10-26 20:58 UTC Move out of draft to request review. Status above doesn't look right?
|
lmolkova
force-pushed
the
lmolkova/typed-span-record-exception
branch
from
October 23, 2026 23:37
1ef3e8d to
e89504d
Compare
lmolkova
added this pull request to stack #5822
October 24, 2026 01:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5820.
Part of #4561 (span event API deprecation, OTEP 4430).
In the SDK,
_start_typed_span/_start_as_current_typed_spannow defaultrecord_exceptiontoFalse. An exception escaping the block still sets the span status toERRORby default (set_status_on_exceptionstaysTrue). Callers can opt back in withrecord_exception=True.Since these methods are experimental, changing the default now is allowed, and it means instrumentations moving to span types won't keep emitting exception span events by default.
start_span/start_as_current_spanare unchanged.For tracers without span type support, the call is delegated to that tracer's own methods, so their defaults apply when the flag isn't set.