ui: make search placeholder in service main tabs dynamic#26511
Merged
harsh-vador merged 1 commit intomainfrom Mar 16, 2026
Merged
ui: make search placeholder in service main tabs dynamic#26511harsh-vador merged 1 commit intomainfrom
harsh-vador merged 1 commit intomainfrom
Conversation
Code Review ✅ ApprovedUpdates search placeholder text in service main tabs to be dynamic rather than static. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
|
Contributor
🟡 Playwright Results — all passed (21 flaky)✅ 3332 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 183 skipped
🟡 21 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
anuj-kumary
approved these changes
Mar 16, 2026
Contributor
|
Changes have been cherry-picked to the 1.12.2 branch. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
(cherry picked from commit 94aa334)
JRDuncan
pushed a commit
to JRDuncan/OpenMetadata
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Fixes #26510
Issue
The search bar placeholder in service details pages (such as Database Service, API Service) was using the service type name template (e.g., "Search for Database Service"). This was slightly confusing since users are searching for the assets listed in the table (like Databases, Topics, or Collections), rather than searching for the service itself.
Solution
Updated the search placeholder to be dynamic based on the asset type and tab label. It now correctly populates with corresponding labels, such as:
"Search for Databases" (for Database Service)
"Search for Topics" (for Messaging Service)
"Search for Collections" (for API Service)
This matches the active tab name exactly, making the search bar fully intuitive for users.
Screen.Recording.2026-03-16.at.2.01.37.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>