Skip to content

ui: make search placeholder in service main tabs dynamic#26511

Merged
harsh-vador merged 1 commit intomainfrom
fix-service-placeholder
Mar 16, 2026
Merged

ui: make search placeholder in service main tabs dynamic#26511
harsh-vador merged 1 commit intomainfrom
fix-service-placeholder

Conversation

@harsh-vador
Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #26510

Issue

The search bar placeholder in service details pages (such as Database Service, API Service) was using the service type name template (e.g., "Search for Database Service"). This was slightly confusing since users are searching for the assets listed in the table (like Databases, Topics, or Collections), rather than searching for the service itself.

Solution

Updated the search placeholder to be dynamic based on the asset type and tab label. It now correctly populates with corresponding labels, such as:
"Search for Databases" (for Database Service)
"Search for Topics" (for Messaging Service)
"Search for Collections" (for API Service)
This matches the active tab name exactly, making the search bar fully intuitive for users.

Screen.Recording.2026-03-16.at.2.01.37.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harsh-vador harsh-vador self-assigned this Mar 16, 2026
@harsh-vador harsh-vador requested a review from a team as a code owner March 16, 2026 08:36
@harsh-vador harsh-vador added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Mar 16, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Mar 16, 2026

Code Review ✅ Approved

Updates search placeholder text in service main tabs to be dynamic rather than static. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.04% (57439/86967) 45.65% (30397/66579) 48.63% (9107/18726)

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (21 flaky)

✅ 3332 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 183 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 451 0 4 2
🟡 Shard 2 303 0 2 1
🟡 Shard 3 657 0 4 33
🟡 Shard 4 721 0 6 47
✅ Shard 5 591 0 0 67
🟡 Shard 6 609 0 5 33
🟡 21 flaky test(s) (passed on retry)
  • Features/EntityRenameConsolidation.spec.ts › Classification - multiple rename + update cycles should preserve tags (shard 1, 1 retry)
  • Flow/Tour.spec.ts › Tour should work from help section (shard 1, 1 retry)
  • Flow/Tour.spec.ts › Tour should work from URL directly (shard 1, 1 retry)
  • Pages/Customproperties-part1.spec.ts › Timestamp (shard 1, 1 retry)
  • Features/ColumnBulkOperations.spec.ts › should update display name and propagate to all occurrences (shard 2, 1 retry)
  • Flow/CustomizeWidgets.spec.ts › Domains Widget (shard 2, 1 retry)
  • Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › EditAll User: Complete export-import-validate flow (shard 3, 1 retry)
  • Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 3, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit action on test case (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/UserProfileOnlineStatus.spec.ts › Should update online status in real-time when user becomes active (shard 4, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataProductAndSubdomains.spec.ts › Add tags to data product via UI (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Verify domain data products count includes subdomain data products (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with deeply nested subdomains (3+ levels) verifies FQN propagation (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
  • Pages/Login.spec.ts › Refresh should work (shard 6, 2 retries)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@harsh-vador harsh-vador enabled auto-merge (squash) March 16, 2026 10:28
@harsh-vador harsh-vador merged commit 94aa334 into main Mar 16, 2026
36 of 42 checks passed
@harsh-vador harsh-vador deleted the fix-service-placeholder branch March 16, 2026 10:30
@github-actions
Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 1.12.2 branch.

github-actions bot pushed a commit that referenced this pull request Mar 16, 2026
JRDuncan pushed a commit to JRDuncan/OpenMetadata that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Search placeholder in Service Main Tabs shows Service Name instead of Asset Name

2 participants