Search refactoring updates#23742
Conversation
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
| await redirectToHomePage(page); | ||
| await followingSearchResponse; | ||
|
|
||
| await page.reload(); |
There was a problem hiding this comment.
WE are redirecting home and again reloading any reason for that?
There was a problem hiding this comment.
removed this code
| await expect( | ||
| page.locator('[data-testid="following-widget"]') | ||
| ).toContainText(domain.data.displayName); | ||
| ).toContainText(domain.data.displayName, { timeout: 15000 }); |
There was a problem hiding this comment.
We shouldn't be increasing timeout instead need to wait for proper API if possible
There was a problem hiding this comment.
removed this code
| await expect( | ||
| page.locator('[data-testid="following-widget"]') | ||
| ).toContainText(subDomain.data.displayName); | ||
| ).toContainText(subDomain.data.displayName, { timeout: 15000 }); |
There was a problem hiding this comment.
removed this code
| await adminPage | ||
| .locator('.ant-select-item-option-content') | ||
| .getByText('Application bot role') | ||
| .click(); |
There was a problem hiding this comment.
Can you check we can do it via testID?
| * @param wildcardTerms - Optional record for wildcard queries | ||
| * @returns Query filter object for searchQuery API | ||
| */ | ||
| export const getTermQuery = ( |
There was a problem hiding this comment.
Add test for this function
There was a problem hiding this comment.
have already added cases but will be added more as well
https://github.com/open-metadata/OpenMetadata/blob/a00481c3e6316f7da73ae1b5551b7600be4ef838/openmetadata-ui/src/main/resources/ui/src/utils/SearchUtils.test.ts
|
|
@chirag-madlani @harsh-vador Will this be cherry picked in 1.10.2? |
8 participants
Describe your changes:
Fixes #22498
I worked on refactoring search to avoid AND and OR operators inside q params
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>