fix: Domain client event handlers no longer disappear#1922
fix: Domain client event handlers no longer disappear#1922man85 wants to merge 2 commits intoopen-feature:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates EventSupport.java to return a new HashSet of domain names and adds a test case to OpenFeatureAPITest.java to ensure that configuration change events are correctly handled for both domainless and domain-specific providers. A review comment correctly identified that a TODO suggestion in the code regarding Set.copyOf was misleading, as the caller requires a mutable set to perform removeAll operations without triggering an UnsupportedOperationException.
man85
changed the title
man85
force-pushed
the
fix/issues-1919-provider-event-handlers-disappearing
branch
from
1a71f09 to
701c7b8
Compare
man85
force-pushed
the
fix/issues-1919-provider-event-handlers-disappearing
branch
from
701c7b8 to
9b3ce4a
Compare
man85
force-pushed
the
fix/issues-1919-provider-event-handlers-disappearing
branch
from
156009d to
e4fcbe8
Compare
beeme1mr
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
============================================
+ Coverage 92.25% 93.26% +1.00%
- Complexity 653 656 +3
============================================
Files 59 59
Lines 1589 1589
Branches 179 179
============================================
+ Hits 1466 1482 +16
+ Misses 76 62 -14
+ Partials 47 45 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: man85 <man85@yandex.ru>
Signed-off-by: man85 <man85@yandex.ru>
man85
force-pushed
the
fix/issues-1919-provider-event-handlers-disappearing
branch
from
e4fcbe8 to
f9bd55e
Compare
|
aepfli
left a comment
aepfli
left a comment
There was a problem hiding this comment.
Thank you for catching and fixing this.
3 participants
This PR
Related Issues
Fixes #1919
Notes
Follow-up Tasks
How to test