Skip to content

ENH: enable site search with pagefind - #915

Merged
mattip merged 1 commit into
numpy:mainfrom
InessaPawson:searchbox-pagefind
Oct 9, 2026
Merged

mattip merged 1 commit into
numpy:mainfrom
InessaPawson:searchbox-pagefind

Conversation

@InessaPawson

Copy link
Copy Markdown
Member

Enable site search with Pagefind.
This covers numpy.org pages only. The Sphinx docs are not included.
NB: Pagefind builds a separate index for each language (en, pt, ja, es) based on the page's lang attribute.
Addresses #263.

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit d1297cd
🔍 Latest deploy log https://app.netlify.com/projects/numpy-org/deploys/6abc4f649296fc0009051996
😎 Deploy Preview https://deploy-preview-915--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@InessaPawson InessaPawson linked an issue Sep 29, 2026 that may be closed by this pull request
@stefanv

stefanv commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Code changes LGTM; the aesthetics of the find button are dubious, but also something we can address later.

@InessaPawson

Copy link
Copy Markdown
Member Author

the aesthetics of the find button are dubious, but also something we can address later.

@stefanv Are you planning to update the search button design at the theme level, or should we think of an override specific to numpy.org?

@stefanv

stefanv commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

It should probably done on the theme level; but there is no-one working on that design at the moment.

@InessaPawson

Copy link
Copy Markdown
Member Author

@stefanv I’ve filed scientific-python/scientific-python-hugo-theme#724 so we can capture the idea. Maybe we’ll get to it someday.:)

@InessaPawson
InessaPawson requested a review from mattip October 8, 2026 15:31
@mattip
mattip merged commit 390b204 into numpy:main Oct 9, 2026
4 checks passed
@mattip

mattip commented Oct 9, 2026

Copy link
Copy Markdown
Member

Thanks @InessaPawson

@mattip mattip mentioned this pull request Oct 9, 2026
@InessaPawson
InessaPawson deleted the searchbox-pagefind branch October 10, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search box needed

3 participants