Unify promoter implementations and align behavior with NumPy - #120
Open
ngoldbaum wants to merge 3 commits into
Open
Unify promoter implementations and align behavior with NumPy#120ngoldbaum wants to merge 3 commits into
ngoldbaum wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues I noticed while looking over PR #118 today.
First, it unifies the promoter implementations to use a shared helper. Second, it updates the promoter logic to be more consistent with NumPy.
Currently, one can trigger errors due to ambiguous promotion. It's also not currently possible to do e.g.
np.add(quad, quad, dtype='float64'). This fixes both issues. See the tests. I also deleted the existing promoter tests because they're duplicative with the new tests.I used an AI model for help with this.