Skip to content

ci: improve workflows #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luc122c wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ci: improve workflows #3147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37a0502
ci: guard runs to npmx repo
luc122c Aug 5, 2026
3174dd1
ci: use ubuntu-slim where possible
luc122c Aug 5, 2026
a0dcf38
ci: make codecov uploads paralell.
luc122c Aug 5, 2026
1bcc6f8
ci: zizmor requires docker.
luc122c Aug 5, 2026
c96614d
ci: change lint job to run on ubuntu-24.04-arm
luc122c Aug 5, 2026
a08aea2
Apply suggestion from @coderabbitai[bot]
luc122c Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/chromatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ permissions:
jobs:
chromatic:
name: 📚 Chromatic
if: github.repository == 'npmx-dev/npmx.dev'
runs-on: ubuntu-24.04-arm

steps:
Expand Down
84 changes: 43 additions & 41 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,26 +77,27 @@ jobs:
- name: 🧪 Unit tests
run: vp test --project unit --coverage --reporter=default --reporter=junit --outputFile=test-report.junit.xml

- name: ⬆︎ Upload test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: test-report.junit.xml
flags: unit
report_type: test_results
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: ⬆︎ Upload coverage reports to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: coverage/clover.xml
flags: unit
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
- parallel:
- name: ⬆︎ Upload test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: test-report.junit.xml
flags: unit
report_type: test_results
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: ⬆︎ Upload coverage reports to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: coverage/clover.xml
flags: unit
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

test:
name: 🧪 Component tests
Expand All @@ -119,26 +120,27 @@ jobs:
- name: 🧪 Component tests
run: vp test --project nuxt --coverage --reporter=default --reporter=junit --outputFile=test-report.junit.xml

- name: ⬆︎ Upload test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: test-report.junit.xml
flags: component
report_type: test_results
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: ⬆︎ Upload coverage reports to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: coverage/clover.xml
flags: component
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
- parallel:
- name: ⬆︎ Upload test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: test-report.junit.xml
flags: component
report_type: test_results
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: ⬆︎ Upload coverage reports to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
disable_search: true
files: coverage/clover.xml
flags: component
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

browser:
name: 🖥️ Browser tests
Expand Down Expand Up @@ -234,7 +236,7 @@ jobs:

i18n:
name: 🌐 i18n validation
runs-on: ubuntu-24.04-arm
runs-on: ubuntu-slim

steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
deploy-canary:
if: github.repository == 'npmx-dev/npmx.dev'
name: 🚀 Deploy to canary (main.npmx.dev)
runs-on: ubuntu-24.04-arm
runs-on: ubuntu-slim
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lunaria.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
jobs:
lunaria-overview:
name: 🌝 Generate Lunaria Overview
if: github.repository == 'npmx-dev/npmx.dev'
runs-on: ubuntu-24.04-arm
permissions:
contents: read
Expand All @@ -36,4 +37,4 @@
sfw: true

- name: Generate Lunaria Overview
uses: lunariajs/action@4911ad0736d1e3b20af4cb70f5079aea2327ed8e # astro-docs

Check warning on line 40 in .github/workflows/lunaria.yml

View workflow job for this annotation

GitHub Actions / 🌈 GitHub Actions security analysis

stale-action-refs 

lunaria.yml:40: commit hash does not point to a Git tag: this step
2 changes: 1 addition & 1 deletion .github/workflows/mirror-tangled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
mirror:
name: 🕸️ Mirror to Tangled
if: ${{ github.repository == 'npmx-dev/npmx.dev' }}
runs-on: ubuntu-24.04-arm
runs-on: ubuntu-slim

@ghostdevv ghostdevv Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come?

@luc122c luc122c Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner only gets 1vcpu and 5GB RAM which should be enough to clone the repo. It also has less tools but still includes Git and OpenSSL tools. It also runs in a container instead of a full VM so it's faster to provision.

The only reason I see not to use it would be if the resources aren't enough and it's taking a long time to push.

Screenshot 2026-08-06 at 7 29 09 pm https://docs.github.com/en/actions/reference/runners/github-hosted-runners

@ghostdevv ghostdevv Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we used arm seems to be given here: #829 (comment) - not sure how that factors in

@luc122c luc122c Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if anything it should be faster than the arm runners as they still run in a full VM. The only reason I could see them being slower is CPU/RAM bottleneck which is why I've only swapped small jobs, not the ones with full installs.


steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ permissions: {}
jobs:
stale-bugs:
name: 🧹 Mark stale bug issues
runs-on: ubuntu-latest
runs-on: ubuntu-slim
permissions:
issues: write # mark and close stale bug issues
steps:
Expand All @@ -33,7 +33,7 @@ jobs:

stale-prs:
name: 🧹 Mark stale pull requests
runs-on: ubuntu-latest
runs-on: ubuntu-slim
permissions:
pull-requests: write # mark and close stale pull requests
steps:
Expand Down
Loading