Skip to content

fix(i18n): add missing translation key for noodles 404 #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 2 commits into from
Jul 22, 2026
Merged

fix(i18n): add missing translation key for noodles 404 #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40f9a52
fix(i18n): make a missing noodle string translatable
igorskyflyer Jul 20, 2026
9213cbb
fix(i18n): update translation schema
igorskyflyer Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/pages/noodles/[slug].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ if (import.meta.server && !noodle.value) {

<template v-else>
<p class="font-mono text-xs tracking-widest uppercase text-fg-subtle mb-3">
404 — empty bowl
404 — {{ $t('noodles.missing.empty_bowl') }}
</p>
<h1 class="font-mono text-3xl sm:text-4xl font-medium tracking-tight mb-4">
{{ $t('noodles.missing.title') }}
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,8 @@
"back_to_archive": "Back to all noodles",
"missing": {
"title": "This noodle never made it out of the bowl.",
"body": "We don't have a “{slug}” noodle on the menu. Either it's still being plated, or it was never written. Either way — back to the archive."
"body": "We don't have a “{slug}” noodle on the menu. Either it's still being plated, or it was never written. Either way — back to the archive.",
"empty_bowl": "empty bowl"
}
},
"settings": {
Expand Down
3 changes: 3 additions & 0 deletions i18n/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,9 @@
},
"body": {
"type": "string"
},
"empty_bowl": {
"type": "string"
}
},
"additionalProperties": false
Expand Down
Loading