fix: deduplicate id="provenance" - #2976
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesProvenance Section Anchor Removal
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello! Thank you for opening your first PR to npmx, @GauBen! 🚀 Here’s what will happen next:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gameroman
left a comment
There was a problem hiding this comment.
Hmm, do you know how/why does it happen in the first place?
|
@gameroman because this section: npmx.dev/app/pages/package/[[org]]/[name].vue Lines 1088 to 1092 in 04a35e7 contains this section: I removed |
|
Thank you! That makes sense 👍 I wonder if we can completely avoid the nested |
|
Thanks for your first contribution, @GauBen! 🚀 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
🔗 Linked issue
Hi!
Small fix, no related issue
🧭 Context
id="provenance"may appear twice in the page ifprovenanceDatais definedhttps://github.com/search?q=repo%3Anpmx-dev%2Fnpmx.dev+%22id%3D%5C%22provenance%22&type=code
📚 Description
Issue discovered with Pa11y