Skip to content

feat: show timeline chart with steps instead of spline - #2954

Merged
graphieros merged 1 commit into
mainfrom
2953-timeline-stepper
Jun 24, 2026
Merged

feat: show timeline chart with steps instead of spline#2954
graphieros merged 1 commit into
mainfrom
2953-timeline-stepper

Conversation

@graphieros

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolves #2953

🧭 Context

The size / deps change isn't gradual but happens on release.

📚 Description

Show steps instead of a spline on the timeline chart:

Dark mode Light mode
image image

@graphieros graphieros linked an issue Jun 23, 2026 that may be closed by this pull request
3 tasks
@vercel

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jun 23, 2026 2:37pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Jun 23, 2026 2:37pm
npmx-lunaria Ignored Ignored Jun 23, 2026 2:37pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Style
    • Updated timeline chart visualisation to display data using step-based line rendering instead of smooth curves for improved readability across all datasets.

Walkthrough

The package timeline chart changes two line series, totalSize and dependencyCount, from smooth curves to stepped rendering in the existing chart configuration.

Changes

Timeline chart rendering

Layer / File(s) Summary
Stepped series configuration
app/components/Package/TimelineChart.vue
The totalSize and dependencyCount line datasets replace smooth: true with useStepper: true in the chart series configuration.

Possibly related PRs

  • npmx-dev/npmx.dev#2663: Also changes app/components/Package/TimelineChart.vue line-series rendering behaviour and appears directly related to this chart configuration update.

Suggested reviewers

  • userquin
  • gameroman
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing spline interpolation with step visualization in the timeline chart.
Description check ✅ Passed The description is directly related to the changeset, explaining the context and showing visual comparisons of the updated chart in both themes.
Linked Issues check ✅ Passed The code changes directly implement the requirement from #2953 by replacing smooth spline rendering with step-based visualization on the timeline chart.
Out of Scope Changes check ✅ Passed All changes are scoped to the timeline chart visualization configuration, directly addressing the linked issue with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2953-timeline-stepper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/components/Package/TimelineChart.vue`:
- Line 190: The useStepper property set to true in the TimelineChart.vue
component is not supported in vue-data-ui version 3.22.0 and will be ignored by
the library. Remove the useStepper: true lines from the configuration objects
where they appear (around lines 190 and 203) since stepped line rendering is not
currently implemented in vue-data-ui. This will clean up the code by removing
unsupported properties that have no effect.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6250bae9-5d11-4c26-8b13-901b5a59c1db

📥 Commits

Reviewing files that changed from the base of the PR and between a11045f and e9452c6.

📒 Files selected for processing (1)
  • app/components/Package/TimelineChart.vue

Comment thread app/components/Package/TimelineChart.vue
@graphieros
graphieros requested a review from 43081j June 23, 2026 14:49
@graphieros graphieros added the needs review This PR is waiting for a review from a maintainer label Jun 23, 2026
@gameroman gameroman added the front Frontend, Design label Jun 23, 2026
@ghostdevv
ghostdevv added this pull request to the merge queue Jun 23, 2026
@ghostdevv
ghostdevv removed this pull request from the merge queue due to a manual request Jun 23, 2026
@ghostdevv

Copy link
Copy Markdown
Member

oh, will wait for James' review 👀

@graphieros

graphieros commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

oh, will wait for James' review 👀

He said it looked good to him on the design channel, but there is a pro/con debate going on, so I'll wait a bit

@gameroman gameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@graphieros
graphieros added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit a93b547 Jun 24, 2026
28 checks passed
@graphieros
graphieros deleted the 2953-timeline-stepper branch June 24, 2026 05:40
@github-actions github-actions Bot mentioned this pull request Jun 24, 2026
@graphieros graphieros removed the needs review This PR is waiting for a review from a maintainer label Jun 24, 2026
BittuBarnwal7479 pushed a commit to BittuBarnwal7479/npmx.dev that referenced this pull request Jun 27, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front Frontend, Design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change timeline curve type to step-after

3 participants