feat: show timeline chart with steps instead of spline - #2954
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThe package timeline chart changes two line series, ChangesTimeline chart rendering
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/Package/TimelineChart.vue`:
- Line 190: The useStepper property set to true in the TimelineChart.vue
component is not supported in vue-data-ui version 3.22.0 and will be ignored by
the library. Remove the useStepper: true lines from the configuration objects
where they appear (around lines 190 and 203) since stepped line rendering is not
currently implemented in vue-data-ui. This will clean up the code by removing
unsupported properties that have no effect.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6250bae9-5d11-4c26-8b13-901b5a59c1db
📒 Files selected for processing (1)
app/components/Package/TimelineChart.vue
|
oh, will wait for James' review 👀 |
He said it looked good to him on the design channel, but there is a pro/con debate going on, so I'll wait a bit |
🔗 Linked issue
Resolves #2953
🧭 Context
The size / deps change isn't gradual but happens on release.
📚 Description
Show steps instead of a spline on the timeline chart: