fix: set frame-ancestors 'none' to prevent embedding - #2926
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThe security headers module adds global and Nuxt devtools route-specific ChangesCSP frame-ancestors response headers
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Probably still nice to have I think 👍 |
🔗 Linked issue
🧭 Context
disables embedding using frame-ancestors
📚 Description
noticed that it was possible to embed npmx.dev in a slidev presentation- this aims to harden things by adding an additional cspedit - this was based on an out-of-date experience! #2075 already fixes this, but unsure if we still want to add frame-ancestors as boot-and-braces?