-
-
Notifications
You must be signed in to change notification settings - Fork 514
feat: increase text and interactive elems contrast #2621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
586fa0e
feat: increase text and interactive elems contrast
alexdln 74e3a5b
Merge branch 'main' into feat/color-contrast
alexdln 62c7e1e
feat: add foreground shade select
alexdln 9dee40d
feat: add foreground shade to command palette
alexdln c7bab73
test: add tests for foreground shade
alexdln 5b2a8f5
chore: resolve conflicts
alexdln 55fc44f
chore: increase contrast for versions selector
alexdln 33ab9bf
chore: resolve conflicts
alexdln f364d4e
chore: apply suggestion
alexdln 7063882
Merge branch 'main' into feat/color-contrast
ghostdevv cafa3df
Merge remote-tracking branch 'origin/main' into feat/color-contrast
ghostdevv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| <script setup lang="ts"> | ||
| const { foregroundThemes, selectedForegroundTheme, setForegroundTheme } = useForegroundTheme() | ||
|
|
||
| onPrehydrate(el => { | ||
| const settings = JSON.parse(localStorage.getItem('npmx-settings') || '{}') | ||
| // Hardcoded — onPrehydrate is serialized into a <script> tag and cannot reference imports | ||
| const defaultId = 'standard' | ||
| const id = settings.preferredForegroundTheme | ||
| if (id) { | ||
| const input = el.querySelector<HTMLInputElement>(`input[value="${id}"]`) | ||
| if (input) { | ||
| input.checked = true | ||
| input.setAttribute('checked', '') | ||
| } | ||
| // Remove checked from the server-default (clear button, value="") | ||
| if (id !== defaultId) { | ||
| const clearInput = el.querySelector<HTMLInputElement>(`input[value="${defaultId}"]`) | ||
| if (clearInput) { | ||
| clearInput.checked = false | ||
| clearInput.removeAttribute('checked') | ||
| } | ||
| } | ||
| } | ||
| }) | ||
| </script> | ||
|
|
||
| <template> | ||
| <fieldset | ||
| class="flex items-center gap-4 has-[input:focus-visible]:(outline-solid outline-accent/70 outline-offset-4) rounded-xl w-fit" | ||
| > | ||
| <legend class="sr-only">{{ $t('settings.foreground_themes.label') }}</legend> | ||
| <label | ||
| v-for="theme in foregroundThemes" | ||
| :key="theme.id" | ||
| class="size-6 rounded-full transition-transform duration-150 motion-safe:hover:scale-110 has-[:checked]:(ring-2 ring-fg ring-offset-2 ring-offset-bg-subtle) has-[:focus-visible]:(ring-2 ring-fg ring-offset-2 ring-offset-bg-subtle)" | ||
| :style="{ backgroundColor: theme.value }" | ||
| > | ||
| <input | ||
| type="radio" | ||
| name="foreground-theme" | ||
| class="sr-only" | ||
| :value="theme.id" | ||
| :checked=" | ||
| selectedForegroundTheme === theme.id || | ||
| (!selectedForegroundTheme && theme.id === 'standard') | ||
| " | ||
| :aria-label="theme.label" | ||
| @change="setForegroundTheme(theme.id)" | ||
| /> | ||
| </label> | ||
| </fieldset> | ||
| </template> | ||
|
|
||
| <style scoped> | ||
| @media (forced-colors: active) { | ||
| /* keep background theme swatches visible in forced colors. */ | ||
| label { | ||
| forced-color-adjust: none; | ||
| border: 1px solid CanvasText; | ||
|
|
||
| &:has(> input:checked) { | ||
| outline: 2px solid Highlight; | ||
| outline-offset: 2px; | ||
| } | ||
| } | ||
| } | ||
| </style> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.