Repository navigation
[10.0] Translate ToString() on string expressions - #4050
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #4047 to
hotfix/10.0.4.Return string-mapped instances unchanged in
NpgsqlObjectToStringTranslator, matching SQL Server and SQLite. Includes regression coverage for string predicates, null propagation, object-typed grouping keys used inOrderBy/Where, and inherited GearsOfWar/TPC/TPT string projection SQL assertions. Release-branch adaptations are limited to the TPC/TPT file locations and EF 10's element sorter nullable annotation.Fixes #4046.
Related to dotnet/efcore#20839 and its upstream fix dotnet/efcore#29349.
Validation: .NET SDK 10.0.300 with VSTest against a dedicated PostgreSQL 17 container, with both inherited shared connection variables unset. All 10 focused regressions passed; the broader string translation and
ToString_selection passed 160/160 tests.