Repository navigation
[10.0] Fix Last() on primitive collections returning the first array element - #3956
Merged
Merged
Conversation
Backport #3925 to hotfix/10.0.4, preserving descending ordinality for Last/LastOrDefault and retaining later tables during unnest cleanup. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 655047e3-ebb2-4a2e-9817-c998f679450e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #3925 (reviewed commit
32c2baac5209aaebade01d5ef287db3d9fb0a2fa) tohotfix/10.0.4for #3909.WITH ORDINALITYforLast()/LastOrDefault(); ascending cleanup andFirst()SQL remain unchanged.Last()/LastOrDefault()regression tests without other behavior changes.Validation
dotnet build test/EFCore.PG.FunctionalTests: succeeded with no warnings or errors on .NET SDK 10.0.300 / EF Core 10.0.4.Test__Npgsql__DefaultConnection='Host=localhost': both new regressions, First/FirstOrDefault, Single/SingleOrDefault, joins, SelectMany, Skip/Take, descending ElementAt, and inherited-test override coverage.