Repository navigation
Map byte[] to json/jsonb as a raw JSON document again - #3935
Open
Aykuttonpc wants to merge 1 commit into
Open
Aykuttonpc wants to merge 1 commit into
Aykuttonpc wants to merge 1 commit into
Conversation
byte[] mapped to a json/jsonb column was picked up as a primitive collection of bytes, so it was written as a JSON array of numbers and failed to read existing JSON documents. Unless an element mapping is explicitly configured, fall back to NpgsqlJsonTypeMapping as before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3698
Since 10.0, a byte[] property mapped to a json/jsonb column is picked up by NpgsqlTypeMappingSource.FindCollectionMapping as a JSON primitive collection of bytes. It is written as a JSON array of numbers, and rows holding real JSON documents (e.g. written by 9.x) fail to materialize with "Invalid token type: 'StartObject'".
This restores the 9.x behavior, using the same approach as the multidimensional array fix (#3663): unless an element mapping is explicitly configured (e.g. via PrimitiveCollection()), FindCollectionMapping returns null for byte[] on json/jsonb, so FindBaseMapping falls back to NpgsqlJsonTypeMapping, which sends the bytes as the raw UTF-8 document as supported by Npgsql. The default bytea mapping and the byte[] -> smallint[] array mapping are unaffected.
Tests
Notes