Repository navigation
Register PG extensions in the model by convention - #2161
Merged
Merged
Conversation
roji
force-pushed
the
PluginExtensionConventions
branch
2 times, most recently
from
December 17, 2021 19:16
b032373 to
b181606
Compare
|
Any reason not to add these extensions always? I assume there's a high chance they would be needed when the plugin is used. |
Member
Author
|
For the NetTopologySuite plugin you're right - I'll do that at the minimum to avoid yet another pass over the model. The problem is with the convention in the provider itself, for types which rare (hstore, ltree, lquery...); I definitely don't want to add those fringe extensions for everyone... |
By scanning property types in the model. Closes npgsql#2137
roji
force-pushed
the
PluginExtensionConventions
branch
from
December 20, 2021 19:03
b181606 to
f577c05
Compare
|
Once dotnet/efcore#9329 is implemented this shouldn't be too bad perf-wise |
roji
force-pushed
the
PluginExtensionConventions
branch
from
December 30, 2021 15:01
0a1e3b4 to
351d6a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By scanning property types in the model.
@AndriySvyryd, this adds two ModelFinalizing conventions which scan all properties, get their type mappings, and for certain supported types that are known to require PostgreSQL extensions, adds those to the model. Up to now users have had to add these explicitly. Any intuition on whether this is problematic perf-wise?
Closes #2137