Skip to content

Document the new timeout and cancellation behavior #47

Open

Description

@roji

Activity

  1. self-assigned this
    on Sep 18, 2020
  2. transferred this issue fromnpgsql/npgsqlon Sep 19, 2020
  3. added this to the vNext milestone on Oct 16, 2021
  4. removed this from the 7.0.0 milestone on Dec 30, 2021
  5. added this to the 7.0.0 milestone on Jul 4, 2022
  6. removed this from the 7.0.0 milestone on Mar 2, 2025
  7. baal2000 commented on Sep 17, 2025

    @baal2000

    @roji we've ran into the the same misunderstanding as in npgsql/npgsql#4542 (comment) of whether a "cancelled" NpgSqlReader ignores the remaining data in the pipe when disposed or reads to the end.

    What stops you from updating the documentation?

  8. roji commented on Sep 18, 2025

    @roji
    MemberAuthor

    What stops you from updating the documentation?

    Nothing, except time and priority constraints.

  9. baal2000 commented on Sep 18, 2025

    @baal2000

    Understand.

    Just as a suggestion: when this happens, please expand on NpgsqlDataReader.Close and NpgsqlDataReader.CloseAsync by posting a remark similar to SqlDataReader.Close:

    ...This may be a long operation depending on the amount of data to be consumed...

    and

    ...the time to close may be shortened by calling the Cancel method of the associated SqlCommand object before the Close method is called...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions