[docs] Docs/issue 309 governance models #356
Merged
dominykas merged 13 commits intonodejs:masterfrom Jul 14, 2020
Merged
Conversation
thescientist13
added
the
package-maintenance-agenda
thescientist13
force-pushed
the
docs/issue-309-governance-models
branch
from
2eacf4b to
904318d
Compare
mhdawson
reviewed
Jun 16, 2020
mhdawson
reviewed
Jun 16, 2020
mhdawson
reviewed
Jun 16, 2020
mhdawson
reviewed
Jun 16, 2020
mhdawson
reviewed
Jun 16, 2020
mhdawson
approved these changes
Jun 16, 2020
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM, with a few suggestions/typo corrections
Contributor
Author
|
Thanks for the extra 👀 @mhdawson , feedback applied! 😃 |
ghinks
approved these changes
Jul 2, 2020
Contributor
ghinks
left a comment
ghinks
left a comment
There was a problem hiding this comment.
Great work @thescientist13.
thescientist13
commented
Jul 2, 2020
Contributor
Author
There was a problem hiding this comment.
Given our discussion around drafts in general in #373 , does anyone have any objection to me just moving this doc out of drafts on this first pass, and removing the draft "label" from the Table of Contents here?
Or should there be an incubation period of sorts for new documentation? I guess in general not sure what constitutes a draft (aside from those with only an outline / sparse content).
larson-carter
approved these changes
Jul 2, 2020
Member
|
I'm happy for it to move out of draft as part of this PR. |
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
thescientist13
force-pushed
the
docs/issue-309-governance-models
branch
from
8e4e1d1 to
2822ab9
Compare
dominykas
reviewed
Jul 5, 2020
dominykas
approved these changes
Jul 5, 2020
dominykas
removed
the
package-maintenance-agenda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #309 (first draft)