Skip to content

fix(ui): fix sidebar height - #9148

Open
Botato300 wants to merge 1 commit into
nodejs:mainfrom
Botato300:fix/ui-sidebar
Open

fix(ui): fix sidebar height#9148
Botato300 wants to merge 1 commit into
nodejs:mainfrom
Botato300:fix/ui-sidebar

Conversation

@Botato300

Copy link
Copy Markdown

Description

Fix the sidebar height. It's a small detail, in the images you can see the differences. The sidebar was moving a few pixels down because of the header's height, so I calculated it in css: 100svh - header height and that's it!

Before
image (2)

After
image (4)

Validation

Just go to any page that has the long sidebar, like /learn. For some reason, it redirects me to nodejs.org instead of a localhost url, so you can go to /en/about/get-involved/events and add several <li> items to the sidebar, and you'll be able to reproduce it!

Related Issues

None

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Botato300
Botato300 requested a review from a team as a code owner September 8, 2026 19:01
@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Sep 8, 2026 7:02pm UTC

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants