Change language picker icon#4503
Conversation
…e as suggested by nodejs#4441. Also fixes when the footer would have no margin in dark mode.
- Changed body background from hex code to variable. - Only remove footer on small screens.
|
Where did the icon come from originally? |
|
It came from http://www.languageicon.org/, see #3503. |
|
@nodejs/website |
|
It shouldn't be a PNG. |
|
It shouldn't be a PNG. |
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
Please use SVG files after optimizing it and no redundant attributes.
|
I have changed the icons to an svg by converting it from |
Since dark mode transition time is used in multiple places, I added a variable so if it needs to be changed it can be changed easily.
|
Is this PR good for merging @XhmikosR ? |
|
Sorry, I can't review the result (this is one of the cases PR previews would go a long way). If someone can confirm everything looks good on both themes, that's good enough from my side judging by the code changes. |
@XhmikosR If you're online right now, here's a preview I'll keep around for the next 30 minutes or so: https://8080-arkinsolomon-nodejsorg-yges5368tg1.ws-us38.gitpod.io/ |
|
Thanks @Trott! Confirmed LGTM. The same optimizations could be made to the dark switcher icons later (inline them, optimize them, toggle the |
5 participants
Fixes #3372. I know this had 2 pull requests created already, with the most recent one dying pretty quickly. It was a pretty simple change to use the new image. I did slightly modify the icon to be white only. It works fine for both light and dark modes.