Skip to content

Redesign suggests all versions of Node.js include corepack #6441

Description

@richardlau

URL:

https://nodejs-org-git-meta-remove-legacy-website-code-openjs.vercel.app/en/download

Browser Name:

Firefox

Browser Version:

115.8.0

Operating System:

Windows 11

How to reproduce the issue:

In the redesign it looks like the download page unconditionally includes the string "and corepack":

Node.js includes <LinkWithArrow href="https://npmjs.com">npm</LinkWithArrow> (<Release.NpmVersion />) and corepack.

This means the string is always present, even if you select a really old version of Node.js e.g. v8.17.0.

AFAIK there is currently no quick way of determining if an arbitrary release of Node.js includes corepack short of looking at the source for the version or unpacking one of the archives. Corepack is not indexed in index.json/index.tab and is unlikely to be while it is experimental.

Activity

  1. richardlau commented on Mar 5, 2024

    @richardlau
    MemberAuthor

    image

  2. AugustinMauroy commented on Mar 5, 2024

    @AugustinMauroy
    Member

    There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

  3. ovflowd commented on Mar 5, 2024

    @ovflowd
    Member

    There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

    Apparently not. @richardlau, when was Corepack introduced? We can make an if statement to not render this to versions it is known for not being supported. Or should we remove the mention from corepack in the meanwhile until the TSC has an agreement on whether we should or should not have it there? Cc @nodejs/tsc

  4. added
    tsc-agendaAgenda items for the next Technical Steering Committee meeting
    website redesignIssue/PR part of the Node.js Website Redesign
    on Mar 5, 2024
  5. richardlau commented on Mar 5, 2024

    @richardlau
    MemberAuthor

    There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

    Apparently not. @richardlau, when was Corepack introduced? We can make an if statement to not render this to versions it is known for not being supported. Or should we remove the mention from corepack in the meanwhile until the TSC has an agreement on whether we should or should not have it there? Cc @nodejs/tsc

    According to the links from nodejs/node#39608 16.9.0 and 14.9.0. It's not available in any version of Node.js 13.x and below.
    I'd prefer not to mention it until its future is decided. The pre-redesign website doesn't mention it.

  6. mhdawson commented on Mar 8, 2024

    @mhdawson
    Member

    I'd prefer not to mention it until its future is decided

    Thats my preference as well.

  7. ovflowd commented on Mar 8, 2024

    @ovflowd
    Member

    cc @nodejs/nodejs-website feel free to make a PR (or @ruyadorno) cc @nodejs/tsc for awareness.

  8. ruyadorno commented on Mar 8, 2024

    @ruyadorno
    Member

    Sorry I was OOO this week and I could not follow up with the conversation on #6396. @ovflowd feel free to either reopen that PR or open a new one please. 😊

  9. ovflowd commented on Apr 2, 2024

    @ovflowd
    Member

    I've removed the Corepack mention for the time being, until the TSC decides the future of Corepack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tsc-agendaAgenda items for the next Technical Steering Committee meetingwebsite redesignIssue/PR part of the Node.js Website Redesign

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions