Skip to content

test: const/let, strictEqual in symlink-dir-junct - #9928

Closed
walterbm wants to merge 1 commit into
nodejs:masterfrom
walterbm:test-fs-symlink-dir-junction
Closed

test: const/let, strictEqual in symlink-dir-junct#9928
walterbm wants to merge 1 commit into
nodejs:masterfrom
walterbm:test-fs-symlink-dir-junction

Conversation

@walterbm

@walterbm walterbm commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • change var to const/let
  • change assert.equal to asset.strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@jasnell

jasnell commented Dec 5, 2016

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 6, 2016

Copy link
Copy Markdown
Member

Raspberry Pi build failure in CI is unrelated.

@Trott

Trott commented Dec 6, 2016

Copy link
Copy Markdown
Member

Landed in b91ca7d.
Thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants