test: Improvement for testing of execSync

.editorconfig

@@ -0,0 +1,39 @@
+root = true
+
+[*]
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+
+[vcbuild.bat]
+end_of_line = crlf
+
+[*.{md,markdown}]
+trim_trailing_whitespace = false
+
+[{lib,src,test}/**.js]
+indent_style = space
+indent_size = 2
+
+[src/**.{h,cc}]
+indent_style = space
+indent_size = 2
+
+[test/*.py]
+indent_style = space
+indent_size = 2
+
+[configure]
+indent_style = space
+indent_size = 2
+
+[Makefile]
+indent_style = tab
+indent_size = 8
+
+[{deps,tools}/**]
+indent_style = ignore
+indent_size = ignore
+end_of_line = ignore
+trim_trailing_whitespace = ignore
+charset = ignore

.eslintignore

@@ -1,6 +1,8 @@
+lib/internal/v8_prof_polyfill.js
 lib/punycode.js
-test/addons/doc-*/
+test/addons/??_*/
 test/fixtures
-test/**/node_modules
 test/disabled
 test/tmp*/
+tools/eslint
+node_modules

.eslintrc

@@ -1,106 +1,136 @@
 env:
   node: true
-
-# enable ECMAScript features
-ecmaFeatures:
-  blockBindings: true
-  templateStrings: true
-  octalLiterals: true
-  binaryLiterals: true
-  generators: true
-  forOf: true
-  objectLiteralShorthandProperties: true
-  objectLiteralShorthandMethods: true
-  classes: true
+  es6: true
 
 rules:
   # Possible Errors
-  # list: https://github.com/eslint/eslint/tree/master/docs/rules#possible-errors
-  ## check debugger sentence
+  # http://eslint.org/docs/rules/#possible-errors
+  comma-dangle: [2, only-multiline]
+  no-control-regex: 2
   no-debugger: 2
-  ## check duplicate arguments
   no-dupe-args: 2
-  ## check duplicate object keys
   no-dupe-keys: 2
-  ## check duplicate switch-case
   no-duplicate-case: 2
-  ## disallow assignment of exceptional params
+  no-empty-character-class: 2
   no-ex-assign: 2
-  ## disallow use of reserved words as keys like enum, class
-  no-reserved-keys: 2
-  ## disallow unreachable code
+  no-extra-boolean-cast: 2
+  no-extra-parens: [2, functions]
+  no-extra-semi: 2
+  no-func-assign: 2
+  no-invalid-regexp: 2
+  no-irregular-whitespace: 2
+  no-obj-calls: 2
+  no-proto: 2
+  no-template-curly-in-string: 2
+  no-unexpected-multiline: 2
   no-unreachable: 2
-  ## require valid typeof compared string like typeof foo === 'strnig'
+  no-unsafe-negation: 2
+  use-isnan: 2
   valid-typeof: 2
 
   # Best Practices
-  # list: https://github.com/eslint/eslint/tree/master/docs/rules#best-practices
-  ## require falls through comment on switch-case
+  # http://eslint.org/docs/rules/#best-practices
+  dot-location: [2, property]
   no-fallthrough: 2
+  no-global-assign: 2
+  no-multi-spaces: 2
+  no-octal: 2
+  no-redeclare: 2
+  no-self-assign: 2
+  no-unused-labels: 2
+  no-useless-call: 2
+  no-useless-escape: 2
+  no-void: 2
+  no-with: 2
+
+  # Strict Mode
+  # http://eslint.org/docs/rules/#strict-mode
+  strict: [2, global]
+
+  # Variables
+  # http://eslint.org/docs/rules/#variables
+  no-delete-var: 2
+  no-undef: 2
+  no-unused-vars: [2, {args: none}]
+
+  # Node.js and CommonJS
+  # http://eslint.org/docs/rules/#nodejs-and-commonjs
+  no-mixed-requires: 2
+  no-new-require: 2
+  no-path-concat: 2
+  no-restricted-modules: [2, sys, _linklist]
+  no-restricted-properties: [2, {
+    object: assert,
+    property: deepEqual,
+    message: Please use assert.deepStrictEqual().
+  }]
 
   # Stylistic Issues
-  # list: https://github.com/eslint/eslint/tree/master/docs/rules#stylistic-issues
-  ## use single quote, we can use double quote when escape chars
-  quotes: [2, "single", "avoid-escape"]
-  ## 2 space indentation
-  indent: [2, 2]
-  ## add space after comma
+  # http://eslint.org/docs/rules/#stylistic-issues
+  brace-style: [2, 1tbs, {allowSingleLine: true}]
   comma-spacing: 2
-  ## put semi-colon
-  semi: 2
-  ## require spaces operator like var sum = 1 + 1;
-  space-infix-ops: 2
-  ## require spaces return, throw, case
-  space-return-throw-case: 2
-  ## no space before function, eg. 'function()'
-  space-before-function-paren: [2, "never"]
-  ## require space before blocks, eg 'function() {'
-  space-before-blocks: [2, "always"]
-  ## require parens for Constructor
-  new-parens: 2
-  ## max 80 length
-  max-len: [2, 80, 2]
-  ## max 2 consecutive empty lines
-  no-multiple-empty-lines: [2, {max: 2}]
-  ## require newline at end of files
+  comma-style: 2
+  computed-property-spacing: 2
   eol-last: 2
-  ## no trailing spaces
+  func-call-spacing: 2
+  indent: [2, 2, {SwitchCase: 1, MemberExpression: 1}]
+  key-spacing: [2, {mode: minimum}]
+  keyword-spacing: 2
+  linebreak-style: [2, unix]
+  max-len: [2, 80, 2]
+  new-parens: 2
+  no-mixed-spaces-and-tabs: 2
+  no-multiple-empty-lines: [2, {max: 2, maxEOF: 0, maxBOF: 0}]
+  no-tabs: 2
   no-trailing-spaces: 2
-  # require space after keywords, eg 'for (..)'
-  space-after-keywords: 2
-
-  # Strict Mode
-  # list: https://github.com/eslint/eslint/tree/master/docs/rules#strict-mode
-  ## 'use strict' on top
-  strict: [2, "global"]
+  quotes: [2, single, avoid-escape]
+  semi: 2
+  semi-spacing: 2
+  space-before-blocks: [2, always]
+  space-before-function-paren: [2, never]
+  space-in-parens: [2, never]
+  space-infix-ops: 2
+  space-unary-ops: 2
 
-  # Variables
-  # list: https://github.com/eslint/eslint/tree/master/docs/rules#variables
-  ## disallow use of undefined variables (globals)
-  no-undef: 2
+  # ECMAScript 6
+  # http://eslint.org/docs/rules/#ecmascript-6
+  arrow-parens: [2, always]
+  arrow-spacing: [2, {before: true, after: true}]
+  constructor-super: 2
+  no-class-assign: 2
+  no-confusing-arrow: 2
+  no-const-assign: 2
+  no-dupe-class-members: 2
+  no-new-symbol: 2
+  no-this-before-super: 2
+  prefer-const: [2, {ignoreReadBeforeAssign: true}]
+  rest-spread-spacing: 2
+  template-curly-spacing: 2
 
   # Custom rules in tools/eslint-rules
-  require-buffer: 2
+  align-function-arguments: 2
+  align-multiline-assignment: 2
+  assert-fail-single-argument: 2
+  new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
+  no-definegetter-definesetter: 2
 
 # Global scoped method and vars
 globals:
-  DTRACE_HTTP_CLIENT_REQUEST           : false
-  LTTNG_HTTP_CLIENT_REQUEST            : false
-  COUNTER_HTTP_CLIENT_REQUEST          : false
-  DTRACE_HTTP_CLIENT_RESPONSE          : false
-  LTTNG_HTTP_CLIENT_RESPONSE           : false
-  COUNTER_HTTP_CLIENT_RESPONSE         : false
-  DTRACE_HTTP_SERVER_REQUEST           : false
-  LTTNG_HTTP_SERVER_REQUEST            : false
-  COUNTER_HTTP_SERVER_REQUEST          : false
-  DTRACE_HTTP_SERVER_RESPONSE          : false
-  LTTNG_HTTP_SERVER_RESPONSE           : false
-  COUNTER_HTTP_SERVER_RESPONSE         : false
-  DTRACE_NET_STREAM_END                : false
-  LTTNG_NET_STREAM_END                 : false
-  COUNTER_NET_SERVER_CONNECTION_CLOSE  : false
-  DTRACE_NET_SERVER_CONNECTION         : false
-  LTTNG_NET_SERVER_CONNECTION          : false
-  COUNTER_NET_SERVER_CONNECTION        : false
-  escape                               : false
-  unescape                             : false
+  COUNTER_HTTP_CLIENT_REQUEST: false
+  COUNTER_HTTP_CLIENT_RESPONSE: false
+  COUNTER_HTTP_SERVER_REQUEST: false
+  COUNTER_HTTP_SERVER_RESPONSE: false
+  COUNTER_NET_SERVER_CONNECTION: false
+  COUNTER_NET_SERVER_CONNECTION_CLOSE: false
+  DTRACE_HTTP_CLIENT_REQUEST: false
+  DTRACE_HTTP_CLIENT_RESPONSE: false
+  DTRACE_HTTP_SERVER_REQUEST: false
+  DTRACE_HTTP_SERVER_RESPONSE: false
+  DTRACE_NET_SERVER_CONNECTION: false
+  DTRACE_NET_STREAM_END: false
+  LTTNG_HTTP_CLIENT_REQUEST: false
+  LTTNG_HTTP_CLIENT_RESPONSE: false
+  LTTNG_HTTP_SERVER_REQUEST: false
+  LTTNG_HTTP_SERVER_RESPONSE: false
+  LTTNG_NET_SERVER_CONNECTION: false
+  LTTNG_NET_STREAM_END: false

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,17 @@
+<!--
+Thank you for reporting an issue.
+Please fill in as much of the template below as you're able.
+
+Version: output of `node -v`
+Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
+Subsystem: if known, please specify affected core module name
+
+If possible, please provide code that demonstrates the problem, keeping it as
+simple and free of external dependencies as you are able.
+-->
+
+* **Version**:
+* **Platform**:
+* **Subsystem**:
+
+<!-- Enter your issue details below this comment. -->

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,22 @@
+<!--
+Thank you for your pull request. Please review below requirements.
+
+Bug fixes and new features should include tests and possibly benchmarks.
+
+Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
+-->
+
+##### Checklist
+<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
+
+- [ ] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes
+- [ ] tests and/or benchmarks are included
+- [ ] documentation is changed or added
+- [ ] commit message follows commit guidelines
+
+##### Affected core subsystem(s)
+<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->
+
+
+##### Description of change
+<!-- Provide a description of the change below this comment. -->

.gitignore

@@ -19,12 +19,14 @@ node_g
 /.project
 /.cproject
 icu_config.gypi
+.eslintcache
 
 /out
 
 # various stuff that VC++ produces/uses
 Debug/
-!node_modules/debug/
+!**/node_modules/debug/
+!deps/v8/src/debug/
 Release/
 !doc/blog/**
 *.sln
@@ -40,16 +42,21 @@ _UpgradeReport_Files/
 ipch/
 *.sdf
 *.opensdf
+*.VC.opendb
+.vs/
+.vscode/
 
 /config.mk
 /config.gypi
+/config_fips.gypi
 *-nodegyp*
 /gyp-mac-tool
 /dist-osx
 /npm.wxs
 /tools/msvs/npm.wixobj
+/tools/msvs/genfiles/
 /tools/osx-pkg.pmdoc/index.xml
-/test/addons/doc-*/
+/test/addons/??_*/
 email.md
 deps/v8-*
 deps/icu
@@ -71,6 +78,9 @@ deps/openssl/openssl.xml
 deps/openssl/openssl.target.mk
 deps/zlib/zlib.target.mk
 
+# not needed and causes issues for distro packagers
+deps/npm/node_modules/.bin/
+
 # build/release artifacts
 /*.tar.*
 /SHASUMS*.txt*