Repository navigation
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66875 +/- ##
==========================================
- Coverage 90.73% 90.70% -0.03%
==========================================
Files 801 801
Lines 280710 280710
Branches 54178 54171 -7
==========================================
- Hits 254709 254629 -80
- Misses 16196 16255 +59
- Partials 9805 9826 +21
🚀 New features to boost your workflow:
|
Member
|
FYI for others, const arr = [];
arr[arr.length] = 'X'Keeps an array PACKED in all active release lines, so it is a valid optimization for avoiding Primordials |
Collaborator
Collaborator
Contributor
Failed to resume CI
Full Auto Start CI output |
Contributor
Failed to resume CI
Full Auto Start CI output |
Contributor
Failed to resume CI
Full Auto Start CI output |
Contributor
Failed to resume CI
Full Auto Start CI output |
Collect active event names with indexed writes instead of calling the primordial push function for each name. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
rozzilla
force-pushed
the
events-optimize-event-names
branch
from
November 18, 2026 08:00
b6119be to
edba83e
Compare
gurgunday
approved these changes
Nov 18, 2026
jasnell
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use indexed appends when collecting active names in
EventEmitter.eventNames(), avoiding a primordial push call per name. Key ordering and filtering of removed listeners remain unchanged.Local benchmarks on Apple M2/macOS with
V8 15.6show higher throughput:Across 26 cases and 3,120 samples, seven gains were confirmed in both comparison directions after Holm correction. No corrected-significant regressions were detected, including listener-read and emission controls.