build: pass target architecture to small-icu genccode - #65095
Merged
Conversation
Signed-off-by: ulofiai <monsterking@tutamail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
i18n-api
avivkeller
approved these changes
Aug 7, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
StefanStojanovic
approved these changes
Aug 17, 2026
Collaborator
richardlau
added
the
commit-queue
Collaborator
|
Landed in 8b9f89f |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: ulofiai <monsterking@tutamail.com> PR-URL: #65095 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: ulofiai <monsterking@tutamail.com> PR-URL: #65095 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
Signed-off-by: ulofiai <monsterking@tutamail.com> PR-URL: #65095 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58751.
Pass the target architecture to
genccodewhen converting trimmed ICU data into a Windows object file. Windows builds use ClangCL, whose ICU COFF writer requires-c <target_arch>; without it, the small-ICU path passes a null architecture andgenccodeexits with an access violation.The full-ICU Windows path already supplies the same option. This change makes the small-ICU path consistent.
Tests: GYP syntax validation and
git apply --checkagainst the specified base and Node.js v24.2.0. The Windows build command was not run in this environment.