doc: note that watch mode reruns all files with isolation none - #65038
Open
ethanresnick wants to merge 1 commit into
Open
doc: note that watch mode reruns all files with isolation none#65038ethanresnick wants to merge 1 commit into
ethanresnick wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
There was a problem hiding this comment.
Pull request overview
Updates the node:test documentation to clarify how watch mode interacts with the --test-isolation setting, aligning the docs with the current behavior when running tests in a shared process.
Changes:
- Add a note to the Watch mode section explaining that rerun scope differs between
--test-isolation=process(affected files) and--test-isolation=none(all files).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+616
to
+619
| This is subject to the isolation mode. With `--test-isolation=process` (the | ||
| default), only the test files affected by the change are rerun. With | ||
| `--test-isolation=none`, every test file in the run is rerun, because those | ||
| files share a single process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Watch mode section promises that a change "will rerun the tests affected by
the change", with no isolation caveat, and the
isolationoption is documentedpurely as where tests run. But the two interact:
watchFiles''changed'handler restarts only the files owning the change under
isolation: 'process',and a single child running the whole file list under
isolation: 'none'(runner.js#L659-L672).
Verified on v26.5.0 with two test files, editing only the first:
Docs-only; this describes current behavior rather than changing it. Whether the
behavior itself should change is #65037 — if it does, this paragraph goes away
with it.