deps: fix ELF note section parsing alignment in postject - #65029
Closed
KoHaRxnP wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
avivkeller
requested changes
Aug 5, 2026
avivkeller
left a comment
avivkeller
left a comment
Member
There was a problem hiding this comment.
Changes to postject belong in it's dedicated repo
Author
Thank you for the feedback! I have submitted the fix to the upstream repository as requested: nodejs/postject#109 I will close this PR for now and open a dependency update PR once it's merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where Single Executable Application (SEA) tests fail when Node.js is compiled using LLD (
zig cc/clangwith lld).Details
postject_find_resourceindeps/postject/postject-api.hpreviously hardcoded note section padding to 4 bytes (roundup(..., 4)). On 64-bit ELF binaries produced by LLD, notes use 8-byte alignment (phdr->p_align), which led to offset misalignment and segment errors. This PR updates the logic to dynamically calculate padding usingphdr->p_align.sizeof(name)instrncmp(which evaluated to pointer size) withname_len(strlen(name)/n_nameszcheck).Testing
python3 tools/test.py --mode=release seaon an ARM64/x86_64 build usingzig cc.100%).