Skip to content

[v24.x backport] node:stream/iter and QUIC backports#64675

Open
aduh95 wants to merge 120 commits into
nodejs:v24.x-stagingfrom
aduh95:stream-iter-and-quic-backports
Open

[v24.x backport] node:stream/iter and QUIC backports#64675
aduh95 wants to merge 120 commits into
nodejs:v24.x-stagingfrom
aduh95:stream-iter-and-quic-backports

Conversation

@aduh95

@aduh95 aduh95 commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport of:

@aduh95
aduh95 requested a review from a team as a code owner July 22, 2026 11:54
@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/performance
  • @nodejs/releasers
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 22, 2026
@aduh95
aduh95 marked this pull request as draft July 22, 2026 11:55
@aduh95
aduh95 force-pushed the stream-iter-and-quic-backports branch from 935ead8 to 1a1c988 Compare July 22, 2026 11:57
@aduh95
aduh95 marked this pull request as ready for review July 22, 2026 11:57
@aduh95
aduh95 marked this pull request as draft July 22, 2026 11:58
@aduh95
aduh95 force-pushed the stream-iter-and-quic-backports branch from 1a1c988 to 975ed7b Compare July 22, 2026 11:58
@aduh95
aduh95 marked this pull request as ready for review July 22, 2026 11:59
@aduh95
aduh95 marked this pull request as draft July 22, 2026 11:59
@aduh95
aduh95 force-pushed the stream-iter-and-quic-backports branch from 975ed7b to 2b26bbe Compare July 22, 2026 12:00
@aduh95
aduh95 marked this pull request as ready for review July 22, 2026 12:00
@aduh95
aduh95 force-pushed the stream-iter-and-quic-backports branch 4 times, most recently from b28dcf7 to 3c553ff Compare July 22, 2026 13:32
@aduh95
aduh95 changed the base branch from v24.19.0-proposal to v24.x-staging July 22, 2026 13:33
@aduh95
aduh95 marked this pull request as draft July 22, 2026 13:33
@aduh95
aduh95 marked this pull request as ready for review July 22, 2026 13:33
@aduh95
aduh95 force-pushed the stream-iter-and-quic-backports branch from 3c553ff to 173b666 Compare July 22, 2026 13:37
jasnell and others added 3 commits July 22, 2026 15:46
@jasnell @aduh95
deps: add ngtcp2 test binaries
4deef48 
The goal here is to add the ngtcp2 client and server
samples so that we can use them in CI to test our QUIC
implementation.

PR-URL: nodejs#59946
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell @aduh95
tests: start adding quic test server utilities
2dd99d8 
PR-URL: nodejs#59946
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@sravani1510 @aduh95
build: fix flags for ngtcp2 on IBM i
7eb3ceb 
PR-URL: nodejs#60073
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95
aduh95 force-pushed the stream-iter-and-quic-backports branch 2 times, most recently from e2831df to 7e7fa1a Compare July 22, 2026 14:12
Aditi-1400 and others added 3 commits July 22, 2026 17:52
@Aditi-1400 @aduh95
crypto: make --use-system-ca per-env rather than per-process
6249b4b 
PR-URL: nodejs#60678
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot @aduh95
deps: update ngtcp2 to 1.19.0
843a514 
PR-URL: nodejs#61156
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@nodejs-github-bot @aduh95
deps: update ngtcp2 to 1.20.0
ef37d35 
PR-URL: nodejs#61511
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell and others added 29 commits July 22, 2026 22:43
@jasnell @aduh95
quic: add applicationOptions to session
a3afef4 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#63267
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: add doc note about certificate size limitations
20079ca 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: flip preferred address policy default to 'ignore'
63998fb 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: refine rate limiting
5188cc6 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: add session creation rate limiting
f2cdd00 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus 4.6
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: cache timestamp for address lru cache
b441cf2 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: add rate limiting docs
ffb311c 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus 4.6
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: handle h3 max header size option
2152b10 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: improve peer cert verification
f87297f 
On the client, add verifyPeer: 'auto', 'strict', and
'manual' modes. The 'strict' mode will reject invalid
certs at the handshake layer, while the 'manual' mode
allows the application to inspect the peer cert and decide
whether to trust it or not. The 'auto' mode is the default
and will reject invalid certs at a middle layer after the
onhandshake event.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus 4.6
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: add block list support for endpoints
aaf0d57 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus 4.6
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: add stream idle timeout
b4716e6 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell @aduh95
quic: support hostname verification
3a4b52e 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#63483
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@pimterry @aduh95
quic: add proper error codes & messages for QUIC failures
3bc484f 
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63198
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@jasnell @aduh95
quic: add listEndpoints API
62bcfd7 
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#63536
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@pimterry @aduh95
quic: fix broken listEndpoints export, test callbacks & nghttp3 include
8ed1bc9 
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63874
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@martenrichter @aduh95
quic: impl. cb for http/3 settings/app. options
cdaee83 
Implements a callback that is invoked once http/3
settings are received.
Background, http/3 settings usually arrive a bit
later than connection establishment, and e.g. for
webtransport these settings are used to indicate
support. So e.g. the examples for quiche from
 google, wait for the settings to arrive.
 (This is different to http/2).
The implemented callback mechanism allows to wait
for the settings to arrive until connection
attempts are made. As settings are stored in the
generic applications option object, the callback's
 name refers to the application rather than the
 settings. Whether this is a good choice is
 debatable.

Fixes: nodejs#63553
Signed-off-by: Marten Richter <marten.richter@freenet.de>
PR-URL: nodejs#63558
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@pimterry @aduh95
quic: fix reader backpressure deadlock on idle connections
bff6164 
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@pimterry @aduh95
quic: expose QUIC certificates as JS X509Certificate, not raw handles
c37c58a 
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63191
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@pimterry @aduh95
quic: fix get_reader bug that dropped data on FIN
b2f8347 
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63946
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@martenrichter @aduh95
quic: fixes undefined handle in QuicStream kInspect
cbc4fab 
If the #handle is undefined and not QuicStream,
 while kInspect is called
 `DataViewPrototypeGetByteLength` will throw.

Signed-off-by: Marten Richter <marten.richter@freenet.de>
PR-URL: nodejs#64170
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@3zrv @aduh95
quic: drop version negotiation packets with oversized CIDs
3ed57aa 
Signed-off-by: Mohamed Sayed <k@3zrv.com>
PR-URL: nodejs#64228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@trivikr @aduh95
doc: clarify fromReadable() duck-typed contract
3e4268b 
Document that duck-typed readable inputs must provide off() in addition
to read() and on(), matching the cleanup behavior in the implementation.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: nodejs#63682
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@aduh95
doc: remove unsupported syntax from stream_iter.md
5256547 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64649
@pimterry @aduh95
build: add QUIC CI job for PRs matching QUIC related paths
8551576 
This notable includes stream/iter (since they're closely related and
rapidly evolving together) and ngtcp2, nghttp3 & openssl deps.

Based on test-linux.yml, the main differences are simplifications: PRs
only, filtered to specific paths, just one build (ARM only), no unusual
characters test.

Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63875
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@Renegade334 @aduh95
meta: update sccache version in test-linux-quic
836dd35 
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: nodejs#64043
Refs: nodejs#63078
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@joyeecheung @aduh95
build: pin envinfo versions in github actions
492c8d4 
Currently they all run `npx envinfo` without pinning the version.
This can be a supply-chain risk.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#64117
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@aduh95
tools: remove envinfo from our workflows
730aa51 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#64259
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@dependabot @aduh95
meta: bump actions/setup-python from 6.2.0 to 6.3.0
0319ba2 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.2.0 to 6.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@a309ff8...ece7cb0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#64241
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@dependabot @aduh95
meta: bump actions/checkout from 6.0.2 to 7.0.0
c1ef609 
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 7.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v6.0.2...9c091bb)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#64245
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
aduh95 force-pushed the stream-iter-and-quic-backports branch from 182db6c to c1ef609 Compare July 22, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.