Skip to content

doc: fix broken links and clean up type map - #64625

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-broken-doc-links
Jul 22, 2026
Merged

doc: fix broken links and clean up type map#64625
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-broken-doc-links

Conversation

@aduh95

@aduh95 aduh95 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

When working on backporting to v24.x-staging commits that have landed on Node.js 26, the doc tooling flagged several links as broken. It's a bit concerning that we're not able to catch those earlier, not only it's bad DX to have broken links for our users, but also it makes backporting really tedious.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jul 20, 2026
@avivkeller

Copy link
Copy Markdown
Member

It's a bit concerning that we're not able to catch those earlier, not only it's bad DX to have broken links for our users, but also it makes backporting really tedious

I believe we have a remark rule in @node-core/remark-lint to catch invalid type map references, let me look on the status of adopting it in core.

@trivikr trivikr added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 21, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 2deb0a1 into nodejs:main Jul 22, 2026
31 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 2deb0a1

aduh95 added a commit that referenced this pull request Jul 30, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #64625
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants