Skip to content

stream: defer readable async iterator listener #63594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trivikr wants to merge 1 commit into from
+9 −2
Closed

stream: defer readable async iterator listener #63594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/internal/streams/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,6 +1380,7 @@ function streamToAsyncIterator(stream, options) {

async function* createAsyncIterator(stream, options) {
let callback = nop;
let isListening = false;

function next(resolve) {
if (this === stream) {
Expand All @@ -1390,15 +1391,18 @@ async function* createAsyncIterator(stream, options) {
}
}

stream.on('readable', next);

let error;
const cleanup = eos(stream, { writable: false }, (err) => {
error = err ? aggregateTwoErrors(error, err) : null;
callback();
callback = nop;
});

function setupReadable() {
isListening = true;
stream.on('readable', next);
}

try {
while (true) {
const chunk = stream.destroyed ? null : stream.read();
Expand All @@ -1409,6 +1413,9 @@ async function* createAsyncIterator(stream, options) {
} else if (error === null) {
return;
} else {
if (!isListening) {
setupReadable();
}
await new Promise(next);
}
}
Expand Down
Loading