Skip to content

streams: simplify readableStreamFromIterable#62651

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:webstreams-from-iterable
Open

streams: simplify readableStreamFromIterable#62651
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:webstreams-from-iterable

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 9, 2026

The intent is to make the code easier for both humans and V8

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.81%. Comparing base (e6ef477) to head (013a1e4).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/webstreams/readablestream.js 73.91% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #62651    +/-   ##
========================================
  Coverage   89.81%   89.81%            
========================================
  Files         697      699     +2     
  Lines      215773   216160   +387     
  Branches    41279    41311    +32     
========================================
+ Hits       193786   194137   +351     
- Misses      14093    14136    +43     
+ Partials     7894     7887     -7     
Files with missing lines Coverage Δ
lib/internal/webstreams/util.js 99.57% <ø> (+4.92%) ⬆️
lib/internal/webstreams/readablestream.js 98.33% <73.91%> (-0.01%) ⬇️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the webstreams-from-iterable branch from b1af05e to 013a1e4 Compare April 9, 2026 20:58
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 9, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 9, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants