Skip to content

fs: handle recursive opendir bufferSize asynchronously - #60307

Open
mohin-io wants to merge 1 commit into
nodejs:mainfrom
mohin-io:fix-opendir-buffer-recursive
Open

fs: handle recursive opendir bufferSize asynchronously#60307
mohin-io wants to merge 1 commit into
nodejs:mainfrom
mohin-io:fix-opendir-buffer-recursive

Conversation

@mohin-io

Copy link
Copy Markdown

Summary

  • use async dir handle reads when draining recursive queues so small bufferSize iterations don't block the event loop
  • centralize buffered dirent emission to keep recursion logic consistent for sync, callback, and promise based reads
  • add a regression test covering fs.promises.opendir with recursive reads and bufferSize: 1

Testing

  • python tools/test.py sequential/test-fs-opendir-recursive (fails: missing built Release/node executable)

Fixes: #55764

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support bufferSize option with recursive mode in fs.opendir

2 participants