sqlite: create authorization api by araujogui · Pull Request #59928 · nodejs/node

araujogui · 2025-09-18T17:21:45Z

nodejs-github-bot · 2025-09-18T17:21:50Z

Review requested:

@nodejs/sqlite

codecov · 2025-09-18T18:45:22Z

Codecov Report

❌ Patch coverage is 88.07339% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.46%. Comparing base (97e55f8) to head (0f4816f).
⚠️ Report is 72 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	88.07%	8 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59928      +/-   ##
==========================================
+ Coverage   88.27%   88.46%   +0.18%     
==========================================
  Files         703      703              
  Lines      207333   207653     +320     
  Branches    39875    40031     +156     
==========================================
+ Hits       183028   183691     +663     
+ Misses      16263    15942     -321     
+ Partials     8042     8020      -22

Files with missing lines	Coverage Δ
src/node_sqlite.h	`80.39% <ø> (ø)`
src/node_sqlite.cc	`80.15% <88.07%> (+0.54%)`	⬆️

... and 79 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-09-25T20:31:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69378/

nodejs-github-bot · 2025-09-26T14:42:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69387/

araujogui · 2025-09-30T14:14:41Z

@addaleax @geeksilva97 are we good to merge?

nodejs-github-bot · 2025-09-30T14:39:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69472/

addaleax · 2025-10-01T09:40:55Z

Landed in b217051

PR-URL: #59928 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136

Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

PR-URL: nodejs#59928 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Notable changes: async_hooks: * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415 buffer: * (SEMVER-MINOR) increase Buffer.poolSize default to 64 KiB (Matteo Collina) #63597 cli: * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708 console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 crypto: * update root certificates to NSS 3.123.1 (Node.js GitHub Bot) #63527 debugger: * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713 fs: * (SEMVER-MINOR) add signal option to fs.stat() (Mert Can Altin) #57775 * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277 * (SEMVER-MINOR) add `throwIfNoEntry` option for fs.stat and fs.promises.stat (Juan José) #61178 * (SEMVER-MINOR) add ignore option to fs.watch (Matteo Collina) #61433 http: * (SEMVER-MINOR) add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155 * (SEMVER-MINOR) add req.signal to IncomingMessage (Akshat) #62541 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 net: * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503 node-api: * (SEMVER-MINOR) support SharedArrayBuffer in napi_create_dataview (Kevin Eady) #60473 * (SEMVER-MINOR) add napi_create_object_with_properties (Miguel Marcondes Filho) #59953 perf_hooks: * (SEMVER-MINOR) move non-standard performance properties to perf_hooks (Chengzhong Wu) #60370 sqlite: * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311 * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 src: * (CVE-2026-21712) handle url crash on different url formats (RafaelGSS) nodejs-private/node-private#816 src,permission: * (SEMVER-MINOR) add --allow-inspector ability (Rafael Gonzaga) #59711 stream: * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426 * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907 test_runner: * (SEMVER-MINOR) align mock timeout api (sangwook) #62820 PR-URL: TODO

araujogui added 6 commits September 18, 2025 11:33

sqlite: create authz method

6bf9173

sqlite: improve error handling

bf0fc42

doc: create setauthorizer method doc

41717ac

doc: lint

60ad323

doc: update doc link

19cdadf

sqlite: remove duplicated proto init

e25f0ce

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 18, 2025

araujogui added 2 commits September 18, 2025 14:29

sqlite: break long lines

e7288f3

sqlite: format code

3662e71

geeksilva97 reviewed Sep 18, 2025

View reviewed changes

Comment thread src/node_sqlite.cc Outdated

addaleax requested changes Sep 18, 2025

View reviewed changes

Comment thread src/node_sqlite.h Outdated

Comment thread src/node_sqlite.cc Outdated

Comment thread src/node_sqlite.h Outdated

araujogui added 2 commits September 22, 2025 20:56

sqlite: store callback in internal field

f63cba7

sqlite: restrict valid authz code

2714896

addaleax approved these changes Sep 23, 2025

View reviewed changes

Comment thread src/node_sqlite.cc Outdated

Comment thread src/node_sqlite.cc Outdated

Comment thread src/node_sqlite.cc Outdated

sqlite: improve authorizer error handling

e66a64c

addaleax reviewed Sep 24, 2025

View reviewed changes

Comment thread src/node_sqlite.h Outdated

sqlite: store authz error in internal object

9e96632

araujogui force-pushed the feat/sqlite-authz branch from fef384f to 9e96632 Compare September 24, 2025 17:40

geeksilva97 reviewed Sep 24, 2025

View reviewed changes

Comment thread src/node_sqlite.cc Outdated

sqlite: refactor authz code validation logic

a1553ef

araujogui force-pushed the feat/sqlite-authz branch from f592978 to a1553ef Compare September 24, 2025 21:58

geeksilva97 reviewed Sep 25, 2025

View reviewed changes

Comment thread src/node_sqlite.cc Outdated

geeksilva97 reviewed Sep 25, 2025

View reviewed changes

Comment thread src/node_sqlite.cc

araujogui added 3 commits September 25, 2025 14:58

sqlite: refactor ToLocalChecked usage

e6ab93d

sqlite: create constants doc

254680d

sqlite: create sqlite_ignore test cases

b51043c

addaleax approved these changes Sep 26, 2025

View reviewed changes

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025

addaleax reviewed Sep 26, 2025

View reviewed changes

Comment thread src/node_sqlite.h Outdated

araujogui added 2 commits September 26, 2025 17:25

sqlite: refactor authz error handling

526216d

sqlite: fix format

0f4816f

geeksilva97 approved these changes Sep 30, 2025

View reviewed changes

geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 1, 2025

addaleax pushed a commit that referenced this pull request Oct 1, 2025

sqlite: create authorization api

b217051

PR-URL: #59928 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

addaleax closed this Oct 1, 2025

cjihrig mentioned this pull request Oct 1, 2025

sqlite: expose authorization API #59916

Closed

targos pushed a commit that referenced this pull request Oct 6, 2025

sqlite: create authorization api

18c79d9

PR-URL: #59928 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

github-actions Bot mentioned this pull request Oct 7, 2025

2025-10-08, Version 24.10.0 (Current) #60136

Merged

github-actions Bot mentioned this pull request Jan 3, 2026

chore(nix): update flake.lock (act, actionlint, awscli2 +25 more) i9wa4/dotfiles#79

Closed

juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026

sqlite: create authorization api

8e07c5c

PR-URL: nodejs#59928 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026

sqlite: create authorization api

00a4c71

PR-URL: nodejs#59928 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026

sqlite: create authorization api

a899991

PR-URL: nodejs#59928 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

juanarbol mentioned this pull request Jul 16, 2026

V22.24.0 proposal #64533

Draft

Uh oh!

Uh oh!

Conversation

araujogui commented Sep 18, 2025

Uh oh!

nodejs-github-bot commented Sep 18, 2025

Uh oh!

Uh oh!

codecov Bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 25, 2025

Uh oh!

nodejs-github-bot commented Sep 26, 2025

Uh oh!

Uh oh!

araujogui commented Sep 30, 2025

Uh oh!

nodejs-github-bot commented Sep 30, 2025

Uh oh!

addaleax commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Sep 18, 2025 •

edited

Loading