Skip to content

test: fix watch tests not including completion messages - #58183

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/fix-broken-watch-tests
May 6, 2025
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/fix-broken-watch-tests

Conversation

@dario-piotrowicz

@dario-piotrowicz dario-piotrowicz commented May 5, 2025 •

Copy link
Copy Markdown
Member

Earlier I merged #57936 which was out of sync with main so it didn't include the watch completion messages introduced in #57926

This causes the watch tests to be failing on main, this PR is addressing this issue

I'm really sorry for the inconvenience 🙇

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 5, 2025
@dario-piotrowicz dario-piotrowicz added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 5, 2025
@github-actions

github-actions Bot commented May 5, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @dario-piotrowicz. Please 👍 to approve.

Comment thread test/sequential/test-watch-mode.mjs Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated typo fix 🙂

@dario-piotrowicz dario-piotrowicz changed the title test: fix watch tests not including completion message test: fix watch tests not including completion messages May 5, 2025
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/fix-broken-watch-tests branch from a919cb9 to 7c8ec53 Compare May 5, 2025 16:58
@codecov

codecov Bot commented May 5, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (4acb854) to head (7c8ec53).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58183   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         630      630           
  Lines      186756   186756           
  Branches    36648    36649    +1     
=======================================
+ Hits       168362   168365    +3     
+ Misses      11193    11190    -3     
  Partials     7201     7201           

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 5, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 5, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@LiviaMedeiros LiviaMedeiros added the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 6102159 into nodejs:main May 6, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 6102159

@dario-piotrowicz
dario-piotrowicz deleted the dario/fix-broken-watch-tests branch May 6, 2025 08:04
@dario-piotrowicz

Copy link
Copy Markdown
Member Author

Thanks a lot @LiviaMedeiros for helping getting this PR landed 🙏

@aduh95 aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels May 8, 2025
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2025
9 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants