src,lib,test: unflag --experimental-webstorage by default by danielmbrasil · Pull Request #57666 · nodejs/node

danielmbrasil · 2025-03-28T17:31:57Z

Added Web Storage support enabled by default, with the option to disable via --no-webstorage.

nodejs-github-bot · 2025-03-28T17:32:02Z

Review requested:

@nodejs/config

mcollina · 2025-03-28T18:00:00Z

To fix the failing test, I would change the error being throw in lib/internal/webstorage.js in a warning, and have localStorage be undefined in that case.

@cjihrig wdyt?

cjihrig · 2025-03-28T18:27:46Z

I would be OK with that behavior. However, the global checking logic in test/common/index.js would probably need to be updated. Otherwise, the new warning will probably be printed for every test that doesn't use localStorage.

danielmbrasil · 2025-03-28T20:28:21Z

I just pushed the suggested changes, and the tests are now passing. @cjihrig, could you please review whether the changes in test/common/index.js make sense?

cjihrig · 2025-03-28T20:32:58Z

Without running the code, it doesn't look correct to me:

globalThis[val] === undefined

By the time we find out that the value is undefined, the warning will have already been emitted, right?

danielmbrasil · 2025-03-28T20:37:00Z

By the time we find out that the value is undefined, the warning will have already been emitted, right?

Yeah, that's right. I'll take a look on how to avoid the warning to be emitted in those cases.

danielmbrasil · 2025-04-02T17:16:05Z

@cjihrig Could you take a look now and see if this is closer to what you were expecting? I added a new check to test/common/index.js that overrides the localStorage getter with an empty object. This prevents the warning from being emitted, and the tests are passing locally.

danielmbrasil · 2025-04-04T18:12:38Z

Moving this as ready for review. I think we should possibly also update doc/api/cli.md and doc/api/globals.md, but I'm not sure how to update those docs for now.

codecov · 2025-04-04T19:06:43Z

Codecov Report

❌ Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.28%. Comparing base (73b5022) to head (890a794).
⚠️ Report is 116 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstorage.js	80.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57666      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.02%     
==========================================
  Files         701      701              
  Lines      206644   206676      +32     
  Branches    39737    39738       +1     
==========================================
+ Hits       182386   182472      +86     
+ Misses      16279    16237      -42     
+ Partials     7979     7967      -12

Files with missing lines	Coverage Δ
lib/internal/process/pre_execution.js	`97.15% <100.00%> (-0.28%)`	⬇️
src/node_options.cc	`77.89% <100.00%> (+0.02%)`	⬆️
src/node_options.h	`97.89% <100.00%> (ø)`
lib/internal/webstorage.js	`91.30% <80.00%> (-8.70%)`	⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina · 2025-04-07T13:58:38Z

A few tests needs fixing but this is good progress!

geeksilva97 · 2025-05-26T13:33:01Z

This PR has some conflicts

mcollina

lgtm

geeksilva97

Appreciate your effort here, Daniel

Node.js 25 became "current" and our CI is now testing it. We now have a failure because "localStorage" is now a thing in Node.js but it's not properly enabled without the arg. So @typescript/vfs, which in the browser detects a "localStorage" and tries to use it (but previously in Node.js wouldn't find it so wouldn't try) finds an implementation that's incomplete. This change activates it, so we don't get the error. But we don't really need it, so this can be wound back when we have a fix in vfs or somewhere else in the stack. Ref: nodejs/node#57666 Ref: microsoft/TypeScript-Website#3449 Ref: microsoft/TypeScript-Website#3450

For now, web storage is enabled by default. Refs: nodejs#57666

For now, web storage is enabled by default. Refs: #57666 PR-URL: #60363 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

因 nodejs/node#57666 原因，与 webStorage 相关的测试暂时不兼容。

…Ozone#329) Node.js 25 became "current" and our CI is now testing it. We now have a failure because "localStorage" is now a thing in Node.js but it's not properly enabled without the arg. So @typescript/vfs, which in the browser detects a "localStorage" and tries to use it (but previously in Node.js wouldn't find it so wouldn't try) finds an implementation that's incomplete. This change activates it, so we don't get the error. But we don't really need it, so this can be wound back when we have a fix in vfs or somewhere else in the stack. Ref: nodejs/node#57666 Ref: microsoft/TypeScript-Website#3449 Ref: microsoft/TypeScript-Website#3450

…rkers The Node 26.x leg added in the previous commit failed CI: Node >=25 enables a native `localStorage` global by default (nodejs/node#57666), which throws a DOMException without --localstorage-file and shadows jsdom's own window.localStorage before vitest-environment-jsdom can install it. Every test touching localStorage saw it as undefined (WhatsNewModal.test.tsx, page.test.tsx's BITB-029 case), while 22.x was unaffected since the global is opt-in-only before Node 25. Pass --no-experimental-webstorage to vitest's worker processes via the now-flat `execArgv` option (Vitest 4 removed the old `poolOptions.threads/forks.execArgv` nesting) so jsdom's localStorage wins again. Verified 773/773 unit tests, lint, and type-check pass locally with the flag applied; confirmed via Node's own changelog that the flag was introduced alongside --experimental-webstorage in v22.4.0, so it's a recognized no-op on the 22.x leg too. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NQfpC1H5MQRgQWuTfyWSMp

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues and PRs related to Node.js configuration and feature settings. needs-ci PRs that need a full CI run. labels Mar 28, 2025

danielmbrasil mentioned this pull request Mar 28, 2025

Unflag --experimental-webstorage #57658

Closed

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch from b925ca4 to db0cda3 Compare April 2, 2025 17:11

danielmbrasil changed the title ~~src: unflag --experimental-webstorage by default~~ src,lib,test: unflag --experimental-webstorage by default Apr 4, 2025

danielmbrasil marked this pull request as ready for review April 4, 2025 18:12

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch 2 times, most recently from 67c3460 to 1857c7f Compare April 7, 2025 16:51

danielmbrasil commented Apr 7, 2025

View reviewed changes

Comment thread test/common/index.js Outdated

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch 2 times, most recently from 3cda35a to f075423 Compare May 26, 2025 18:50

geeksilva97 reviewed May 26, 2025

View reviewed changes

Comment thread doc/api/globals.md Outdated

geeksilva97 reviewed May 27, 2025

View reviewed changes

Comment thread test/parallel/test-webstorage.js Outdated

mcollina approved these changes May 27, 2025

View reviewed changes

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch from 6a4ce9f to 6f567ab Compare May 27, 2025 12:37

geeksilva97 approved these changes May 27, 2025

View reviewed changes

cjihrig reviewed May 27, 2025

View reviewed changes

Comment thread lib/internal/webstorage.js Outdated

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 29, 2025

This was referenced Oct 17, 2025

@typescript/vfs is not Node.js 25 compatible (localStorage.getItem is not a function) microsoft/TypeScript-Website#3449

Closed

Add proper localStorage availability checks to support Node v25 in @typescript/vfs microsoft/TypeScript-Website#3450

Merged

Renegade334 mentioned this pull request Oct 17, 2025

localStorage's behaviour when no or invalid --localstorage-file provided #60303

Closed

rvagg mentioned this pull request Oct 20, 2025

docs(ci): enable localStorage in Node.js 25 to avoid build error FilOzone/synapse-sdk#329

Merged

simonmysun mentioned this pull request Oct 22, 2025

Node v25 breaks tests with Web Storage API vitest-dev/vitest#8757

Closed

6 tasks done

Renegade334 mentioned this pull request Oct 22, 2025

lib: throw from localStorage getter on missing storage path #60351

Merged

deokjinkim added a commit to deokjinkim/node that referenced this pull request Oct 22, 2025

doc: remove unnecessary statement of web storage

88bf5a5

For now, web storage is enabled by default. Refs: nodejs#57666

deokjinkim mentioned this pull request Oct 22, 2025

doc: remove unnecessary statement of web storage #60363

Merged

Yovach mentioned this pull request Oct 24, 2025

Update @typescript/vfs to version 1.6.2 bufbuild/protobuf-es#1274

Merged

brianhelba mentioned this pull request Nov 12, 2025

Issues with Node 25 capricorn86/happy-dom#1950

Open

aduh95 mentioned this pull request Nov 13, 2025

doc,src,lib: clarify experimental status of Web Storage support #60708

Merged

caixw added a commit to issue9/cmfx that referenced this pull request Nov 18, 2025

refactor: actions 将 node 改为 24

c644cf1

因 nodejs/node#57666 原因，与 webStorage 相关的测试暂时不兼容。

coderabbitai Bot mentioned this pull request Mar 27, 2026

Replace Node.js built-ins with Web APIs for browser compatibility airframesio/acars-decoder-typescript#380

Merged

4 of 5 tasks

derekpierre mentioned this pull request Apr 10, 2026

Min dev node version nucypher/taco-web#773

Merged

2 of 7 tasks

Conduitry mentioned this pull request Apr 17, 2026

fix: Fix 500 error due to undefined storage sveltejs/svelte.dev#1939

Closed

3 tasks done

E-Lop mentioned this pull request Jun 16, 2026

test: localStorage funzionante nei test jsdom su Node 25+ (closes #40) E-Lop/entro#42

Merged

kevinswiber mentioned this pull request Jul 7, 2026

test: shield the web suite from Node's built-in web storage withpointbreak/pointbreak#416

Merged

coderabbitai Bot mentioned this pull request Jul 9, 2026

test: clean web runner warnings terarush/ping-uptime#49

Merged

This was referenced Aug 3, 2026

Standardise on Node 24 LTS across Docker, CI and engines rusahu/chordvault#121

Closed

Standardise on Node 24 LTS across Docker, CI and engines rusahu/chordvault#122

Merged

coderabbitai Bot mentioned this pull request Aug 10, 2026

test(a11y): src/scripts/ の設定ロジックに単体テストを追加する keroway/astro-blog#659

Merged

7 tasks done

caugner mentioned this pull request Sep 15, 2026

Node.js 25 adds ErrorEvent and Storage mdn/browser-compat-data#30543

Merged

coderabbitai Bot mentioned this pull request Sep 21, 2026

🐛 (RT) :: PR #160 리뷰 코멘트 반영 Team-return/JOBIS-FE-V2#161

Merged

3 tasks done

jay-tau mentioned this pull request Sep 30, 2026

Release builds use lts/* and will switch to Node 26 around Oct 28, while PR checks stay on Node 24 wealthfolio/wealthfolio#1849

Open

Uh oh!

Conversation

danielmbrasil commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 28, 2025

Uh oh!

mcollina commented Mar 28, 2025

Uh oh!

cjihrig commented Mar 28, 2025

Uh oh!

danielmbrasil commented Mar 28, 2025

Uh oh!

cjihrig commented Mar 28, 2025

Uh oh!

danielmbrasil commented Mar 28, 2025

Uh oh!

danielmbrasil commented Apr 2, 2025

Uh oh!

danielmbrasil commented Apr 4, 2025

Uh oh!

codecov Bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina commented Apr 7, 2025

Uh oh!

Uh oh!

geeksilva97 commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

geeksilva97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

danielmbrasil commented Mar 28, 2025 •

edited

Loading

codecov Bot commented Apr 4, 2025 •

edited

Loading