WIP: gypify msi build

[piscisaureus]

Does not work yet

[piscisaureus]

I got stuck on finding a good way of incorporating code signing (signtool.exe) into the build.

[rvagg]

@piscisaureus what's the problem? it can't just be a separate, intermediate target prior to wix?

[piscisaureus]

it can't just be a separate, intermediate target prior to wix?

That's the way to go indeed. However I didn't find a way to integrate this windows-only step nicely without affecting all the other platform builds.

• signtool.exe modifies the .exe in-place which isn't really compatible with any build system. I'd have to make a copy and sign that.
• The unsigned .exe file would need to have a different name than the final build product (unsigned/node.exe or node-unsigned.exe). This makes the output name depend on the ./configure flags, because on unix platforms (and windows when code signing is disabled) you'd still want to produce 'node.exe' as is done today.

[Qard]

Any progress here, or should I close this as stale?

[thefourtheye]

If WIX is not there in the dictionary we will get NoneType doesn't have ... error. It's better to fail with KeyError in that case.

[jasnell]

@piscisaureus ... What do you want to do with this one?

[piscisaureus]

@jasnell

It seemed like a neat idea to put all (windows) build steps inside gyp files, instead of spread out over gyp, a windows batch file, WiX. But I got stuck because I couldn't figure out how to do certain steps with gyp (e.g. signing the .exe which modifies the file in place and does not map to a gyp concept properly).

Currently I'm not working on this - feel free to close if you think it's not a priority.
It may also be an opportunity for another community member to take up and work on (and take credit for it - I'd be totally cool with that).

[jasnell]

@nodejs/build

[rvagg]

/cc @nodejs/platform-windows

[orangemocha]

Not sure if this a priority, though it's an interesting idea 😄 The main reason for using gyp is to generate projects for different platforms / build systems. Since MSI is 100% Windows-specific, dealing with Wix/MSBuild files directly actually seems easier to me.

[jasnell]

Marked as stalled. If there's no activity in the next few weeks I'll go ahead and close.

[jasnell]

Closing due to lack of activity.