Skip to content

lib: reduce amount of caught URL errors#52658

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:reduce-url-throws
Jun 13, 2024
Merged

lib: reduce amount of caught URL errors#52658
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:reduce-url-throws

Conversation

@anonrig

@anonrig anonrig commented Apr 24, 2024

Copy link
Copy Markdown
Member

Since we have URL.parse() now, we don't need try/catch with new URL(). This will potentially improve the performance of hot paths.

cc @nodejs/url

@anonrig anonrig requested review from GeoffreyBooth and aduh95 April 24, 2024 02:43
@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 24, 2024
@anonrig anonrig force-pushed the reduce-url-throws branch from a66a1c1 to e561d99 Compare April 24, 2024 02:44
avivkeller
avivkeller approved these changes Apr 24, 2024
View reviewed changes

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig force-pushed the reduce-url-throws branch 3 times, most recently from 9cfdd53 to b0f5fed Compare April 24, 2024 02:50
aduh95
aduh95 reviewed Apr 24, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/hooks.js Outdated
aduh95
aduh95 reviewed Apr 24, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/resolve.js Outdated
aduh95
aduh95 reviewed Apr 24, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/translators.js Outdated
aduh95
aduh95 reviewed Apr 24, 2024
View reviewed changes
Comment thread lib/internal/url.js Outdated
joyeecheung
joyeecheung reviewed Apr 24, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/hooks.js Outdated
jasnell
jasnell reviewed Apr 27, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/resolve.js Outdated
@anonrig anonrig force-pushed the reduce-url-throws branch from b5265c6 to a69d20c Compare May 15, 2024 01:26
aduh95
aduh95 reviewed May 15, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/translators.js Outdated
@anonrig anonrig force-pushed the reduce-url-throws branch 2 times, most recently from f85ee6c to 38be5ca Compare May 17, 2024 01:04
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 17, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@nodejs-github-bot

nodejs-github-bot commented May 17, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59264/

@anonrig anonrig force-pushed the reduce-url-throws branch 2 times, most recently from 0cd00d8 to 935e22e Compare May 17, 2024 20:19
aduh95
aduh95 reviewed May 17, 2024
View reviewed changes
Comment thread lib/internal/url.js Outdated
aduh95
aduh95 reviewed May 18, 2024
View reviewed changes
Comment thread lib/internal/source_map/source_map_cache.js
targos pushed a commit that referenced this pull request Jun 20, 2024
@anonrig @targos
lib: reduce amount of caught URL errors
710cf77 
PR-URL: #52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@anonrig
lib: reduce amount of caught URL errors
8bdaf5f 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@anonrig @bmeck
lib: reduce amount of caught URL errors
4b60dda 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
@targos targos mentioned this pull request Jun 25, 2024
Merged
@Karliz24 Karliz24 mentioned this pull request Jul 9, 2024
Open
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@anonrig @joyeecheung
lib: reduce amount of caught URL errors
29dfb97 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@anonrig @joyeecheung
lib: reduce amount of caught URL errors
a51b482 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@anonrig @joyeecheung
lib: reduce amount of caught URL errors
5d03fce 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 31, 2025
@anonrig @joyeecheung
lib: reduce amount of caught URL errors
4780d14 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Feb 5, 2025
@anonrig @joyeecheung
lib: reduce amount of caught URL errors
3b5f6d3 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
@joyeecheung

joyeecheung commented Feb 6, 2025

Copy link
Copy Markdown
Member

backport in #56927

@joyeecheung joyeecheung mentioned this pull request Feb 7, 2025
Closed
@marco-ippolito marco-ippolito mentioned this pull request Mar 6, 2025
Merged
This was referenced Mar 17, 2025
Merged
Merged
Merged
Merged
This was referenced Apr 2, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

@avivkeller avivkeller avivkeller approved these changes

@lemire lemire lemire approved these changes

@jasnell jasnell jasnell approved these changes

@GeoffreyBooth GeoffreyBooth Awaiting requested review from GeoffreyBooth

@targos targos Awaiting requested review from targos

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anonrig @nodejs-github-bot @joyeecheung @lemire @jasnell @targos @aduh95 @avivkeller