Skip to content

doc: add deprecation notice to dirent.path - #51059

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:dirent-path-deprecation-
Dec 5, 2023
Merged

doc: add deprecation notice to dirent.path#51059
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:dirent-path-deprecation-

Conversation

@aduh95

@aduh95 aduh95 commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Looks like we forgot about updating fs.md when working on #51020

@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 5, 2023
@github-actions

github-actions Bot commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module. labels Dec 5, 2023
@debadree25 debadree25 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 5, 2023
@aduh95 aduh95 mentioned this pull request Dec 5, 2023
Merged
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a49b77b into nodejs:main Dec 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in a49b77b

@aduh95
aduh95 deleted the dirent-path-deprecation- branch December 5, 2023 21:17
aduh95 added a commit to aduh95/node that referenced this pull request Dec 5, 2023
@aduh95
doc: add deprecation notice to dirent.path
99ac462 
Refs: nodejs#51020
PR-URL: nodejs#51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@aduh95 @RafaelGSS
doc: add deprecation notice to dirent.path
c45a9a3 
Refs: #51020
PR-URL: #51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 18, 2024
@aduh95 @richardlau
doc: add deprecation notice to dirent.path
194ff6a 
Refs: #51020
PR-URL: #51059
Backport-PR-URL: #51021
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #50976
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aduh95 @richardlau
doc: add deprecation notice to dirent.path
09ad974 
Refs: #51020
PR-URL: #51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. fs Issues and PRs related to file-system APIs and the fs module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95 @nodejs-github-bot @lpinca @MoLow @debadree25 @richardlau